Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully support mariadb #108

Closed
Iain-S opened this issue Jun 29, 2023 · 3 comments
Closed

Fully support mariadb #108

Iain-S opened this issue Jun 29, 2023 · 3 comments

Comments

@Iain-S
Copy link
Collaborator

Iain-S commented Jun 29, 2023

In principle, we should be able to support a wide array of db management systems but we do a few things (the schema change, in particular) which may not work cross-platform.

@Iain-S Iain-S changed the title Support mariadb Fully support mariadb Jul 6, 2023
@Iain-S
Copy link
Collaborator Author

Iain-S commented Jul 6, 2023

#110 adds the basics to be able to support MariaDB but leaves MariaDB users unable to use src-stats. This is because:

  1. smartnoise SQL doesn't support mariadb (but it does support pandas so I wonder whether we could hack it in)
  2. we use asyncpg if smartnoise SQL is turned off and asyncpg is postgres specific (I presume)

Possible solutions are

  1. decouple use_asyncio from use_smartnoisesql whereas we currently do use_asyncio = not use_smartnoisesql
  2. use https://pypi.org/project/aiomysql/ for async mariadb support

@Iain-S
Copy link
Collaborator Author

Iain-S commented Jul 17, 2023

See also #118

@Iain-S
Copy link
Collaborator Author

Iain-S commented Aug 11, 2023

We now support source stats and even snsql queries so I'll consider this done.

@Iain-S Iain-S closed this as completed Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant