Allow support for mix releases in 1.9 #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, we get an error: ** (Mix) Undefined applications: [inet_cidr]
Adzz
commented
Jul 8, 2019
| docs: [source_url: "https://github.com/ajvondrak/remote_ip"]] | ||
| end | ||
|
|
||
| def application do |
There was a problem hiding this comment.
Alternatively we can do this:
def application do
[applications: [:plug, :combine, :inet_cidr]]
endThat might support 1.3 and less better?
Closed
ajvondrak
pushed a commit
that referenced
this pull request
Aug 20, 2019
As noted in #12, #14, #15, #16, #17, and even way back in a comment on a5fb55b, my prior inclination to try to use `:included_applications` and `:applications` separately was ill-fated. Under Elixir 1.9.0, Mix started blowing up properly on `mix release` with ** (Mix) :combine is listed both as a regular application and as an included application So I guess everything should go under `:applications` by design. /shrug I'm trusting this to be backwards-compatible with Elixir 1.3, per the discussions on #1 from way back when. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we get an error:
** (Mix) Undefined applications: [inet_cidr]I think if we put the dep
inet_cidrunder the included_applications it thinks it's an application when it is a library? that's a guess though. Either way i think having them defined in the deps now does what putting them in applications / included_applications used to do.