:combine should not be in :included_applications #16
Comments
Closed
ajvondrak
added a commit
that referenced
this issue
Aug 20, 2019
This fixes an error when building under Mix 1.9.0. See: * a5fb55b#commitcomment-20730235 * elixir-lang/elixir#9163 (comment) Closes #12, #14, #15, #16.
ajvondrak
pushed a commit
that referenced
this issue
Aug 20, 2019
As noted in #12, #14, #15, #16, #17, and even way back in a comment on a5fb55b, my prior inclination to try to use `:included_applications` and `:applications` separately was ill-fated. Under Elixir 1.9.0, Mix started blowing up properly on `mix release` with ** (Mix) :combine is listed both as a regular application and as an included application So I guess everything should go under `:applications` by design. /shrug I'm trusting this to be backwards-compatible with Elixir 1.3, per the discussions on #1 from way back when. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is already a comment suggesting this in the commit: a5fb55b#commitcomment-20730235
My reason for bringing it up: it breaks Docker Elixir builds, see also elixir-lang/elixir#9163 (comment)
The text was updated successfully, but these errors were encountered: