Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Updated azure blob storage destination #9682

Merged
merged 6 commits into from
Jan 24, 2022

Conversation

andriikorotkov
Copy link
Contributor

What

Now each data synchronization for each thread is written to a new blob. The name of the blob is formed as a date + timestamp (just like it works now for S3 and GCS). The files for each stream will be saved in a folder with the name of that stream.

How

2022-01-21_10-04

2022-01-21_10-05

Recommended reading order

  1. x.java

🚨 User Impact 🚨

No impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Jan 21, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jan 21, 2022
@andriikorotkov andriikorotkov temporarily deployed to more-secrets January 21, 2022 08:11 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets January 21, 2022 08:47 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Jan 21, 2022

/test connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1727774178
✅ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1727774178
No Python unittests run

@andriikorotkov andriikorotkov temporarily deployed to more-secrets January 21, 2022 08:53 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets January 21, 2022 09:11 Inactive
@andriikorotkov andriikorotkov marked this pull request as ready for review January 21, 2022 09:17
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Jan 21, 2022

/test connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1727895024
✅ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1727895024
No Python unittests run

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 21, 2022 09:20 Inactive
Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Can you update the PR title to be more descriptive?

If it is quick, can you add a format-specific extension to each blob (e.g. .csv for CSV format)? This is not critical though. I think it can also be done in a future PR that unify the writers across S3, GCS, and Azure blob.

@andriikorotkov andriikorotkov temporarily deployed to more-secrets January 24, 2022 16:28 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Jan 24, 2022

/test connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1740993303
✅ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1740993303
No Python unittests run

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 24, 2022 16:35 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Jan 24, 2022

/publish connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1741065201
✅ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1741065201

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 24, 2022 16:53 Inactive
@andriikorotkov andriikorotkov merged commit df6610b into master Jan 24, 2022
@andriikorotkov andriikorotkov deleted the akorotkov/6063-timestemp branch January 24, 2022 17:04
@andriikorotkov andriikorotkov linked an issue Jan 24, 2022 that may be closed by this pull request
@andriikorotkov andriikorotkov restored the akorotkov/6063-timestemp branch February 11, 2022 15:58
@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 11, 2022 16:00 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 11, 2022 16:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destination Azure Blob Storage: Support writing timestamps
5 participants