-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Updated azure blob storage destination #9682
Conversation
...in/java/io/airbyte/integrations/destination/azure_blob_storage/AzureBlobStorageConsumer.java
Outdated
Show resolved
Hide resolved
...in/java/io/airbyte/integrations/destination/azure_blob_storage/AzureBlobStorageConsumer.java
Show resolved
Hide resolved
...ntegrations/destination/azure_blob_storage/AzureBlobStorageCsvDestinationAcceptanceTest.java
Outdated
Show resolved
Hide resolved
/test connector=connectors/destination-azure-blob-storage
|
...ntegrations/destination/azure_blob_storage/AzureBlobStorageCsvDestinationAcceptanceTest.java
Outdated
Show resolved
Hide resolved
...va/io/airbyte/integrations/destination/azure_blob_storage/csv/AzureBlobStorageCsvWriter.java
Outdated
Show resolved
Hide resolved
...in/java/io/airbyte/integrations/destination/azure_blob_storage/AzureBlobStorageConsumer.java
Outdated
Show resolved
Hide resolved
/test connector=connectors/destination-azure-blob-storage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Can you update the PR title to be more descriptive?
If it is quick, can you add a format-specific extension to each blob (e.g. .csv
for CSV format)? This is not critical though. I think it can also be done in a future PR that unify the writers across S3, GCS, and Azure blob.
/test connector=connectors/destination-azure-blob-storage
|
/publish connector=connectors/destination-azure-blob-storage
|
What
Now each data synchronization for each thread is written to a new blob. The name of the blob is formed as a date + timestamp (just like it works now for S3 and GCS). The files for each stream will be saved in a folder with the name of that stream.
How
Recommended reading order
x.java
🚨 User Impact 🚨
No impact
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes