🎉 Updated azure blob storage destination

[andriikorotkov]

What

Now each data synchronization for each thread is written to a new blob. The name of the blob is formed as a date + timestamp (just like it works now for S3 and GCS). The files for each stream will be saved in a folder with the name of that stream.

How

Recommended reading order

1. x.java

🚨 User Impact 🚨

No impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/SUMMARY.md
  • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • docs/integrations/README.md
  • airbyte-integrations/builds.md
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• Credentials added to Github CI. Instructions.
• /test connector=connectors/<name> command is passing.
• New Connector version released on Dockerhub by running the /publish command described here
• After the connector is published, connector added to connector index as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• Credentials added to Github CI. Instructions.
• /test connector=connectors/<name> command is passing.
• New Connector version released on Dockerhub by running the /publish command described here
• After the new connector version is published, connector version bumped in the seed directory as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed.

[andriikorotkov]

/test connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1830276615
✅ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1830276615
No Python unittests run

[andriikorotkov]

/test connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1830356164
✅ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1830356164
No Python unittests run

[andriikorotkov]

/publish connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1830409899
❌ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1830409899

[lmossman]

@alexandr-shegeda @andriikorotkov this is not the correct way to bump a connector version - this PR only modified the version in the destination_specs.yaml file, which is auto-generated from the destination_definitions.yaml file. destination_definitions.yaml is the file where the version must be bumped, and it the /publish step must succeed (since this builds and pushes the images to dockerhub), and once all of that is done then you can run ./gradlew :airbyte-config:init:processResources to auto-generate the update to the destination_specs.yaml file, as described here: https://docs.airbyte.com/connector-development#publishing-a-connector

[andriikorotkov]

@lmossman Thanks for your comment, but this situation is not standard. I already made these changes about 3 weeks ago and published a new version 0.1.2 in this pull request - #9682. But later my changes were erased. Therefore, I re-merged my changes, but I could not publish the version, because. it has been done before.

[sherifnada]

@andriikorotkov can you help me understand what happened in this PR? some questions:

1. why does the file diff not have any changes except for the spec file?
2. why did we merge if the publish command didn't succeed?

[andriikorotkov]

@sherifnada, Oh sure. I got a request in the troubleshooting channel (https://airbytehq.slack.com/archives/C01MFR03D5W/p1644582384478919) that the user can't find the changes I made to destination-azure-blob-storage in pull request #9682 in the master branch. The changes were published in the same pull request. I checked this information and really didn't find them in the wizard. I found my branch locally and opened a new pull request with all the changes. The publishing of the changes was unsuccessful. version has already been published.

Changes in diff only show changes to one file, because the old changes were reverted by someone on the airbyte team and I didn't refresh the github page to see this. Now version 0.1.2 works correctly and all changes are visible in the master branch. I apologize for the misunderstanding.