Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix migration test snowflake version comparison error #9370

Merged
merged 6 commits into from
Jan 10, 2022

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Jan 10, 2022

After #9063, the check for a greater version in the migration acceptance test fails. This PR switches to using ComparableVersion to compare the semantic versions.

@jrhizor jrhizor temporarily deployed to more-secrets January 10, 2022 00:51 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets January 10, 2022 01:07 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets January 10, 2022 01:10 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets January 10, 2022 01:34 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets January 10, 2022 01:42 Inactive
@jrhizor jrhizor changed the title fix migration test again fix migration test snowflake version comparison error Jan 10, 2022
@jrhizor jrhizor marked this pull request as ready for review January 10, 2022 02:23
@jrhizor jrhizor merged commit 2a600be into master Jan 10, 2022
@jrhizor jrhizor deleted the jrhizor/fix-migration-test-again branch January 10, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant