fix migration test snowflake version comparison error (#9370)

* fix migration test again * disable acceptance tests * re-enable acceptance tests * bring snowflake version back * fix * fix how we compare versions for migration tests
airbytehq · Jan 10, 2022 · 2a600be · 2a600be
1 parent f821ce2
commit 2a600be
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/...ptanceTest/java/io/airbyte/test/automaticMigrationAcceptance/MigrationAcceptanceTest.java b/...ptanceTest/java/io/airbyte/test/automaticMigrationAcceptance/MigrationAcceptanceTest.java
@@ -44,6 +44,7 @@
 import org.junit.jupiter.api.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+import org.testcontainers.utility.ComparableVersion;
 
 /**
  * This class contains an e2e test simulating what a user encounter when trying to upgrade Airybte.
@@ -242,11 +243,9 @@ private static void assertDestinationDefinitionInformation(final ApiClient apiCl
           foundLocalCSVDestinationDefinition = true;
         }
         case "424892c4-daac-4491-b35d-c6688ba547ba" -> {
-          final String[] tagBrokenAsArray = destinationDefinitionRead.getDockerImageTag().replace(".", ",").split(",");
-          assertEquals(3, tagBrokenAsArray.length);
-          assertTrue(Integer.parseInt(tagBrokenAsArray[0]) >= 0);
-          assertTrue(Integer.parseInt(tagBrokenAsArray[1]) >= 3);
-          assertTrue(Integer.parseInt(tagBrokenAsArray[2]) >= 9);
+          final String tag = destinationDefinitionRead.getDockerImageTag();
+          final ComparableVersion version = new ComparableVersion(tag);
+          assertTrue(version.compareTo(new ComparableVersion("0.3.9")) >= 0);
           assertTrue(destinationDefinitionRead.getName().contains("Snowflake"));
           foundSnowflakeDestinationDefinition = true;
         }