Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Helm chart: Allow writing logs to S3 easily #8736

Merged
merged 7 commits into from
Dec 13, 2021
Merged

🐛 Helm chart: Allow writing logs to S3 easily #8736

merged 7 commits into from
Dec 13, 2021

Conversation

vnourdin
Copy link
Contributor

What

The current helm chart is aimed to be used with Minio (chart or external) but not for S3 location.

How

  • add values for S3 env variables
  • mutualize every logs-relative values in a logs section
  • adapt the env configmap
  • create or adapt helpers to manage every logging
  • remove direct access to minio values in worker and scheduler deployments

Also

  • also fixed two non-relative values in temporal and server deployments

🚨 User Impact 🚨

People switching from the old chart to this version must adapt their values, especially minio.* and externalMinio.* that moved to logs.minio.* and logs.externalMinio.*

@github-actions github-actions bot added area/platform issues related to the platform kubernetes labels Dec 13, 2021
@vnourdin vnourdin mentioned this pull request Dec 13, 2021
Closed
@davinchia
Copy link
Contributor

@vnourdin can you run a quick test locally to make sure this is compatible with 0.33.11?

@vnourdin
Copy link
Contributor Author

I just upgraded our staging instance to 0.33.11 with this chart and it works 👌

@davinchia
Copy link
Contributor

Thank you!

@davinchia davinchia merged commit 9e36c38 into airbytehq:master Dec 13, 2021
@vnourdin vnourdin deleted the fix_helm_chart_logs branch December 13, 2021 10:24
@jrhizor jrhizor mentioned this pull request Dec 14, 2021
Merged
@alafanechere alafanechere mentioned this pull request Dec 15, 2021
Closed
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@vnourdin @schlattk
🐛 Helm chart: Allow writing logs to S3 easily (airbytehq#8736)
96e9c70 
* feat(chart): Better logs management

* fix(chart): Bad values access

* ref(chart): comment default ingress host

* ref(chart): Update README

* chore(chart): run pre-commit

* chore(charts): Update readme

* fix(charts): Quote bucket region as it can be empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/platform issues related to the platform community kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vnourdin @davinchia @octavia-squidington-iii