🐛 Helm chart: Allow writing logs to S3 easily

[vnourdin]

What

The current helm chart is aimed to be used with Minio (chart or external) but not for S3 location.

How

• add values for S3 env variables
• mutualize every logs-relative values in a logs section
• adapt the env configmap
• create or adapt helpers to manage every logging
• remove direct access to minio values in worker and scheduler deployments

Also

• also fixed two non-relative values in temporal and server deployments

🚨 User Impact 🚨

People switching from the old chart to this version must adapt their values, especially minio.* and externalMinio.* that moved to logs.minio.* and logs.externalMinio.*

[CLAassistant]

All committers have signed the CLA.

[marcosmarxm]

thanks for the contribution @vnourdin, @davinchia will take a look soon :)

[vnourdin]

I added this value to be consistent with other logs destinations, bur it is not used yet.
Maybe we should remove it and tell in the doc that it's the "fallback" if no minio nor externalMinio is enabled ?

[davinchia]

that's fine!

[davinchia]

Thanks for the contribution. We are going to revamp this soon.

One question to make sure I understand.

Curious, did you test this locally for S3?

[vnourdin]

Yes I have tested, and it is in use on our production instance using S3 !

[davinchia]

@vnourdin looks good! can you resolve the conflicts so I can merge this in? Thanks again!

[vnourdin]

ℹ️ I have been forced to delete then recreate my fork and even if my branch is still named the same, GitHub cannot reconnect this PR to it 😞 I opened a new PR which is up-to-date with master: #8736

[davinchia]

all good!