Use docker for integrations #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-tricot
requested review from
sherifnada,
cgardens and
jrhizor
and removed request for
sherifnada and
cgardens
jrhizor
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Looks good.
How are these going to be built? Separate GitHub projects similar to the Singer structure? I imagine it'd take quite a while to build each of these separately every CI run.
Also, should we be pulling these images in advance for the local build or stop script? Otherwise there will be a big delay before running the job which will be noticeable in the UI for something like running a discovery or a connection check.
|
|
||
| public class PostgreSQLContainerHelper { | ||
|
|
||
| public static String getSingerConfigJson(PostgreSQLContainer db) throws JsonProcessingException { | ||
| return getSingerConfigJson( | ||
| db.getUsername(), | ||
| db.getPassword(), | ||
| db.getHost(), | ||
| "host.docker.internal", |
There was a problem hiding this comment.
Why is this preferable to using the host returned by PostgreSQLContainer / won't this fail in tests?
There was a problem hiding this comment.
because both now run in containers. so the port isn't local to the integration container.
cgardens
approved these changes
Aug 21, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allows integrations to be implemented as a docker image
How
Images can now be describe in the project.
Singer worker will pull the image when running.
Updated the code to work with images instead of python env.
Recommended reading order
dataline-integrations/singer/*Next steps
(thread going: https://gitter.im/docker-java/docker-java, gist of the docker-java: https://gist.github.com/michel-tricot/f124dccdb0063b29c7463415cabec2d7)