add docker to base img #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix the error in #96? |
cgardens
approved these changes
Aug 23, 2020
if this is the case why aren't you just using the java client? |
|
#97 (comment) @jrhizor what I previously had was a different way to make that test command work. i merged #96 and am now just doing exactly the same thing. |
|
@sherifnada you can close this PR. |
yasir1brahim
pushed a commit
to yasir1brahim/airbyte
that referenced
this pull request
Jul 27, 2023
…ytehq#97) Updates facebook-marketing, github, google-analytics-v4, linkedin-ads, and tiktok-marketing to include "credentials" in their list of required fields since credentials are required for these connectors to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently
dockeris needed to run tests, but isn't available inside the java_base image used to run tests. Ideally we can use the docker java client instead of doing this, but until then this is a recourse.