Instance-wide params should only be injected if a connector will be using oauth #8018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
tuliren
approved these changes
Nov 16, 2021
| .withCompleteOauthServerOutputSpecification(Jsons.jsonNode(Map.of( | ||
| API_CLIENT, Map.of( | ||
| "type", "string", | ||
| OAuthConfigSupplier.PATH_IN_CONNECTOR_CONFIG, List.of(CREDENTIALS, API_CLIENT))))))))); |
There was a problem hiding this comment.
The ConnectorSpecification creation logic can be put into a helper method. This logic is needed in multiple places, and most of them share 90% of the parameters. Currently it is a bit hard to read, especially to tell the differences between difference test cases.
There was a problem hiding this comment.
good point thanks!
...sistence/src/main/java/io/airbyte/scheduler/persistence/job_factory/OAuthConfigSupplier.java
Show resolved
Hide resolved
ChristopheDuong
added a commit
that referenced
this pull request
Nov 17, 2021
* Refactor OAuth consent flow with new API * Use input connector configuration in getConsentURL for OAuth flow * Instance-wide params should only be injected if a connector will be using oauth (#8018) * Add test for nested parameters
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…q#7983) * Refactor OAuth consent flow with new API * Use input connector configuration in getConsentURL for OAuth flow * Instance-wide params should only be injected if a connector will be using oauth (airbytehq#8018) * Add test for nested parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #5989
How
webbackend/sources/createendpoints for oauth and merge it into thecompleteOAuthones in this PR, we don't need to inject masked values into connector configs anymore. Therefore, theOAuthConfigSupplieris only used by the Scheduler at runtime to inject real OAuth credentials.OAuthConfigSupplierinjects values into the connector config by first checking oauth predicates from theOAuthConfigSpecificationobject attached to the connector's spec object. It also uses it to filter unwanted property outputs before merging them in the right location as specified by the fieldpath_in_connector_configRecommended reading order
airbyte-scheduler/persistence/src/main/java/io/airbyte/scheduler/persistence/job_factory/OAuthConfigSupplier.java