Implement connector config dependency for OAuth consent URL #7983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
sherifnada
reviewed
Nov 15, 2021
| @@ -75,25 +77,61 @@ public BaseOAuth2Flow(final ConfigRepository configRepository, | |||
| } | |||
|
|
|||
| @Override | |||
| @Deprecated | |||
| public String getSourceConsentUrl(final UUID workspaceId, final UUID sourceDefinitionId, final String redirectUrl) | |||
There was a problem hiding this comment.
do we need to keep this method, or should it be removed in this PR? (not sure what depends on it so just asking, if easy to remove here probably better)
There was a problem hiding this comment.
I removed it and added test to make sure the ones that need to be backward compatible can still be used without authConfigSpecification
sherifnada
approved these changes
Nov 17, 2021
…sing oauth (#8018) * Instance-wide params should only be injected if a connector will be using oauth * Add test for nested parameters * format code * Cleanup code
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…q#7983) * Refactor OAuth consent flow with new API * Use input connector configuration in getConsentURL for OAuth flow * Instance-wide params should only be injected if a connector will be using oauth (airbytehq#8018) * Add test for nested parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #6971
How
Recommended reading order
airbyte-oauth/src/main/java/io/airbyte/oauth/BaseOAuth2Flow.javaairbyte-oauth/src/main/java/io/airbyte/oauth/BaseOAuthFlow.javaairbyte-server/src/main/java/io/airbyte/server/handlers/OAuthHandler.javaairbyte-oauth/src/test/java/io/airbyte/oauth/flows/BaseOAuthFlowTest.java