🐛 Source CockroachDB: Fix cockroach Datatypes #7819
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| package io.airbyte.integrations.source.cockroachdb; | ||
|
|
||
| import com.fasterxml.jackson.databind.JsonNode; | ||
| import com.fasterxml.jackson.databind.node.ObjectNode; | ||
| import io.airbyte.commons.json.Jsons; | ||
| import io.airbyte.db.jdbc.JdbcSourceOperations; | ||
| import java.sql.ResultSet; | ||
| import java.sql.SQLException; | ||
| import java.util.Collections; | ||
|
|
||
| /** | ||
| * Class is the responsible for special Cockroach DataTypes handling | ||
| */ | ||
| public class CockroachJdbcSourceOperations extends JdbcSourceOperations { | ||
|
|
||
| @Override | ||
| protected void putBoolean(ObjectNode node, String columnName, ResultSet resultSet, int index) throws SQLException { | ||
| if ("bit".equalsIgnoreCase(resultSet.getMetaData().getColumnTypeName(index))) { | ||
| node.put(columnName, resultSet.getByte(index)); | ||
| } else { | ||
| node.put(columnName, resultSet.getBoolean(index)); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| protected void putDouble(final ObjectNode node, final String columnName, final ResultSet resultSet, final int index) throws SQLException { | ||
| node.put(columnName, resultSet.getDouble(index)); | ||
| } | ||
|
|
||
| @Override | ||
| protected void putNumber(final ObjectNode node, final String columnName, final ResultSet resultSet, final int index) throws SQLException { | ||
| node.put(columnName, resultSet.getBigDecimal(index)); | ||
| } | ||
|
|
||
| @Override | ||
| public JsonNode rowToJson(ResultSet queryContext) throws SQLException { | ||
| final int columnCount = queryContext.getMetaData().getColumnCount(); | ||
| final ObjectNode jsonNode = (ObjectNode) Jsons.jsonNode(Collections.emptyMap()); | ||
|
|
||
| for (int i = 1; i <= columnCount; i++) { | ||
| try { | ||
| queryContext.getObject(i); | ||
| if (!queryContext.wasNull()) { | ||
| setJsonField(queryContext, i, jsonNode); | ||
| } | ||
| } catch (SQLException e) { | ||
| putCockroachSpecialDataType(queryContext, i, jsonNode); | ||
| } | ||
| } | ||
| return jsonNode; | ||
| } | ||
|
|
||
| private void putCockroachSpecialDataType(ResultSet resultSet, int index, ObjectNode node) throws SQLException { | ||
| String columnType = resultSet.getMetaData().getColumnTypeName(index); | ||
| String columnName = resultSet.getMetaData().getColumnName(index); | ||
| try { | ||
| if ("numeric".equalsIgnoreCase(columnType)) { | ||
| final double value = resultSet.getDouble(index); | ||
| node.put(columnName, value); | ||
| } else { | ||
| node.put(columnName, (Double) null); | ||
| } | ||
| } catch (final SQLException e) { | ||
| node.put(columnName, (Double) null); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be an
elsebranch here? Otherwise the result may be ignored.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added else statement and handling of SQLException as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know what types may go to the
elsebranch or give aSQLException? Depending on what type it can be, defaulting tonullmay or may not be the best solution.