🐛 Source CockroachDB: Fix cockroach Datatypes #7819

alexandertsukanov · 2021-11-10T15:18:52Z

What

SQLException appears in some cases during parsing of Cockroach DB datatypes. Fixed such cases.

How

Override methods from JdbcSourceOperations.java. Created custom CockroachJdbcSourceOperations.java class.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

alexandertsukanov · 2021-11-11T08:37:05Z

/test connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1447970172
✅ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1447970172
No Python unittests run

alexandr-shegeda

LGTM

tuliren · 2021-11-11T16:06:28Z

.../src/main/java/io/airbyte/integrations/source/cockroachdb/CockroachJdbcSourceOperations.java

+    if ("numeric".equalsIgnoreCase(columnType)) {
+      final double value = resultSet.getDouble(index);
+      node.put(columnName, value);
+    }


Should there be an else branch here? Otherwise the result may be ignored.

Added else statement and handling of SQLException as well.

Do we know what types may go to the else branch or give a SQLException? Depending on what type it can be, defaulting to null may or may not be the best solution.

tuliren · 2021-11-11T16:08:47Z

...tegration/java/io/airbyte/integrations/source/cockroachdb/CockroachDbSourceDatatypeTest.java

@@ -315,25 +302,21 @@ protected void initTests() {
            .addExpectedValues("a", "abc", "Миші йдуть;", "櫻花分店", "", null, "\\xF0\\x9F\\x9A\\x80")
            .build());

-    // TODO https://github.com/airbytehq/airbyte/issues/4408
-    // JdbcUtils-> DATE_FORMAT is set as ""yyyy-MM-dd'T'HH:mm:ss'Z'"" for both Date and Time types.
-    // So Time only (04:05:06) would be represented like "1970-01-01T04:05:06Z" which is incorrect


This comment is still relevant since the returned value still have 1970-01-01 in the full date string.

Agreed. Returned back the comment, regarding the DateTime format. However, all java source connectors will send full DateTime in JSON for now. As we need standardization for all related DateTime formats.
Please, see:

airbyte/airbyte-db/lib/src/main/java/io/airbyte/db/DataTypeUtils.java

Line 20 in d71871e

public static final String DATE_FORMAT_PATTERN = "yyyy-MM-dd'T'HH:mm:ss'Z'";

So this behavior will be changed when we will sure all destination connectors are able to parse date and time formats.

Got it. Make sense.

tuliren · 2021-11-11T16:08:58Z

...tegration/java/io/airbyte/integrations/source/cockroachdb/CockroachDbSourceDatatypeTest.java

            .addNullExpectedValue()
            .build());

-    // https://github.com/airbytehq/airbyte/issues/4408
-    // TODO JdbcUtils-> DATE_FORMAT is set as ""yyyy-MM-dd'T'HH:mm:ss'Z'"" for both Date and Time types.
-    // So Time only (04:05:06) would be represented like "1970-01-01T04:05:06Z" which is incorrect


Same for this comment.

The same is related to this one.

alexandertsukanov · 2021-11-12T09:54:01Z

/test connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1452544817
✅ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1452544817
No Python unittests run

alexandertsukanov · 2021-11-12T10:07:25Z

/publish connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1452590301
✅ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1452590301

* BUG-4408: Fix cockroach connectors. * BUG-4408: Handling of spacial DB datatype for Cockroach DB. * BUG-4408: Documentation updates. * BUG-4408: Fix unit test. * BUG-4408: Fixed comments. * BUG-4408: Reformat. * BUG-4408: Bumped spec.

alexandertsukanov added 5 commits November 5, 2021 12:18

BUG-4408: Fix cockroach connectors.

dccaf28

Merge branch 'master' into otsukanov/4408_fix_cockroach_datatypes

1c18aaf

Merge branch 'master' into otsukanov/4408_fix_cockroach_datatypes

b960d56

Merge branch 'master' into otsukanov/4408_fix_cockroach_datatypes

6a23338

BUG-4408: Handling of spacial DB datatype for Cockroach DB.

d557594

alexandertsukanov requested review from tuliren and alexandr-shegeda November 10, 2021 15:18

github-actions bot added the area/connectors Connector related issues label Nov 10, 2021

jrhizor temporarily deployed to more-secrets November 10, 2021 15:29 Inactive

BUG-4408: Documentation updates.

4d13602

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 10, 2021

alexandertsukanov temporarily deployed to more-secrets November 10, 2021 15:31 Inactive

BUG-4408: Fix unit test.

92780fa

alexandertsukanov temporarily deployed to more-secrets November 11, 2021 08:38 Inactive

jrhizor temporarily deployed to more-secrets November 11, 2021 08:39 Inactive

alexandertsukanov linked an issue Nov 11, 2021 that may be closed by this pull request

Source CockroachDB: Connector provides wrong values for some datatypes #4408

Closed

alexandr-shegeda approved these changes Nov 11, 2021

View reviewed changes

alexandr-shegeda marked this pull request as ready for review November 11, 2021 15:11

tuliren approved these changes Nov 11, 2021

View reviewed changes

alexandertsukanov added 2 commits November 12, 2021 11:29

BUG-4408: Fixed comments.

3718f2c

BUG-4408: Reformat.

ab9ac68

alexandertsukanov temporarily deployed to more-secrets November 12, 2021 09:31 Inactive

alexandertsukanov temporarily deployed to more-secrets November 12, 2021 09:33 Inactive

jrhizor temporarily deployed to more-secrets November 12, 2021 09:56 Inactive

jrhizor temporarily deployed to more-secrets November 12, 2021 10:09 Inactive

alexandertsukanov added the area/databases label Nov 12, 2021

BUG-4408: Bumped spec.

e0146b5

alexandertsukanov merged commit b295868 into master Nov 12, 2021

alexandertsukanov deleted the otsukanov/4408_fix_cockroach_datatypes branch November 12, 2021 10:19

alexandertsukanov temporarily deployed to more-secrets November 12, 2021 10:20 Inactive

igrankova added connectors/sources-database connectors/source/cockroachdb labels Jan 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source CockroachDB: Fix cockroach Datatypes #7819

🐛 Source CockroachDB: Fix cockroach Datatypes #7819

alexandertsukanov commented Nov 10, 2021 •

edited

Loading

alexandertsukanov commented Nov 11, 2021 •

edited by github-actions bot

Loading

alexandr-shegeda left a comment

tuliren Nov 11, 2021

alexandertsukanov Nov 12, 2021

tuliren Nov 13, 2021

tuliren Nov 11, 2021

alexandertsukanov Nov 12, 2021

tuliren Nov 13, 2021

tuliren Nov 11, 2021

alexandertsukanov Nov 12, 2021

alexandertsukanov commented Nov 12, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 12, 2021 •

edited by github-actions bot

Loading

🐛 Source CockroachDB: Fix cockroach Datatypes #7819

🐛 Source CockroachDB: Fix cockroach Datatypes #7819

Conversation

alexandertsukanov commented Nov 10, 2021 • edited Loading

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

alexandertsukanov commented Nov 11, 2021 • edited by github-actions bot Loading

alexandr-shegeda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexandertsukanov commented Nov 12, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 12, 2021 • edited by github-actions bot Loading

alexandertsukanov commented Nov 10, 2021 •

edited

Loading

alexandertsukanov commented Nov 11, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 12, 2021 •

edited by github-actions bot

Loading

alexandertsukanov commented Nov 12, 2021 •

edited by github-actions bot

Loading