Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: remove SUB_BUILD env var and references #31027

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Oct 3, 2023

This environment variable can now safely be removed. There are still references to it in docs/ but these need to be deeply revised anyway.

Fixes #30402

@postamar postamar requested a review from a team October 3, 2023 18:28
@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 5:26pm

@octavia-squidington-iii octavia-squidington-iii added area/octavia-cli CDK Connector Development Kit labels Oct 3, 2023
@postamar
Copy link
Contributor Author

postamar commented Oct 3, 2023

Validated these changes by triggering a legacy test action which involves the changed ci_integration_test.sh script: https://github.com/airbytehq/airbyte/actions/runs/6397015404/job/17364102546

edit: it fails, but not because of the changes in this script, see similar run on master: https://github.com/airbytehq/airbyte/actions/runs/6407056676

Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im hitting this approve button very hard.

However, ideally theres an additional approval from anyone who actively develops connectors or the cdk.

Ideally...

@postamar postamar merged commit 53735b6 into master Oct 4, 2023
@postamar postamar deleted the postamar/remove-sub-build-env-var branch October 4, 2023 21:58
@postamar
Copy link
Contributor Author

postamar commented Oct 4, 2023

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gradle: stop gradelizing the entire repo
3 participants