Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: stop gradelizing the entire repo #30402

Closed
postamar opened this issue Sep 13, 2023 · 0 comments · Fixed by #31027
Closed

gradle: stop gradelizing the entire repo #30402

postamar opened this issue Sep 13, 2023 · 0 comments · Fixed by #31027
Labels
team/db-dw-sources Backlog for Database and Data Warehouse Sources team

Comments

@postamar
Copy link
Contributor

postamar commented Sep 13, 2023

Stop gradelizing the entire repo. Instead, gradle should only be used for doing java things. Python connectors and odds-and-ends like octavia-cli don’t care about gradle.

  • Stop including all connectors in settings.gradle. Instead, only include java connectors (test on src/main/java directory existence) and which are GA (test on contents of metadata.yml file)
  • Get rid of SUB_BUILD env var
  • Add new WITH_CONNECTOR env var to selectively include ‘:airbyte-integrations:connectors:$WITH_CONNECTOR’. Figure out a way to also include transitive dependencies to other connectors. It’s not that hard, airbyte-ci already does it, see ‘build_include’ in ‘gradle.py’.
  • Have airbyte-ci set this WITH_CONNECTOR env_var.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/db-dw-sources Backlog for Database and Data Warehouse Sources team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant