Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-source:tinyint-unsigned should not be identified as boolean #18956

Merged
merged 8 commits into from
Nov 14, 2022
Merged

mysql-source:tinyint-unsigned should not be identified as boolean #18956

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3ffd629
mysql-source:tinyint-unsigned should not be identified as boolean
subodh1810 Nov 4, 2022
e1b02be
Merge branch 'master' into tiny-int-unsigned-should-not-boolean
subodh1810 Nov 7, 2022
7a6ee45
Merge branch 'master' into tiny-int-unsigned-should-not-boolean
subodh1810 Nov 11, 2022
28ed631
Merge branch 'master' into tiny-int-unsigned-should-not-boolean
subodh1810 Nov 14, 2022
e0d89f8
upgrade version
subodh1810 Nov 14, 2022
4b57a49
fix encrypted spec
subodh1810 Nov 14, 2022
f5ea2e7
auto-bump connector version
octavia-squidington-iii Nov 14, 2022
38e7d71
Merge branch 'tiny-int-unsigned-should-not-boolean' of https://github…
octavia-squidington-iii Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ource-mysql/src/main/java/io/airbyte/integrations/source/mysql/MySqlSourceOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,15 @@ public void setJsonField(final ResultSet resultSet, final int colIndex, final Ob
}
}
case BOOLEAN -> putBoolean(json, columnName, resultSet, colIndex);
case TINYINT, TINYINT_UNSIGNED -> {
case TINYINT -> {
if (field.getLength() == 1L) {
// TINYINT(1) is boolean
putBoolean(json, columnName, resultSet, colIndex);
} else {
putShortInt(json, columnName, resultSet, colIndex);
}
}
case TINYINT_UNSIGNED -> putShortInt(json, columnName, resultSet, colIndex);
case SMALLINT, SMALLINT_UNSIGNED, MEDIUMINT, MEDIUMINT_UNSIGNED -> putInteger(json, columnName, resultSet, colIndex);
case INT, INT_UNSIGNED -> {
if (field.isUnsigned()) {
Expand Down Expand Up @@ -184,7 +185,7 @@ public MysqlType getFieldType(final JsonNode field) {

switch (literalType) {
// BIT(1) and TINYINT(1) are interpreted as boolean
case BIT, TINYINT, TINYINT_UNSIGNED -> {
case BIT, TINYINT -> {
if (columnSize == 1) {
return MysqlType.BOOLEAN;
}
Expand Down