mysql-source:tinyint-unsigned should not be identified as boolean #18956

subodh1810 · 2022-11-04T08:25:18Z

In PR #18619 we stopped syncing tinyint unsigned values as boolean, we should also not identify them as boolean. This is a non-breaking change since tinyint is anyway never identified as boolean cause the length is not available. This just makes it evident to someone reading the code

subodh1810 · 2022-11-04T08:25:26Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3392279715
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3392279715
No Python unittests run

Build Passed

Test summary info:

All Passed

github-actions · 2022-11-04T08:26:19Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector version
Add changelog
Publish the new version

⚠ Sources (2)

Connector	Version	Changelog	Publish
`source-mysql`	`1.0.13`	✅	✅
`source-mysql-strict-encrypt`	`1.0.13`	✅	⚠ (not in seed)

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

subodh1810 · 2022-11-07T09:29:15Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3409113943
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3409113943
No Python unittests run

Build Passed

Test summary info:

All Passed

subodh1810 · 2022-11-11T10:59:56Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3444500703
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3444500703
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              394    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 293, 331-348, 357-365, 369-374, 380, 413-418, 456-463, 506-508, 511, 576-584, 596-599, 604, 660-661, 667, 670, 706-716, 729-754
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1557    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 27.38s ==================

subodh1810 · 2022-11-14T08:14:11Z

/publish connector=connectors/source-mysql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mysql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3459638517

Connector	Did it publish?	Were definitions generated?
connectors/source-mysql-strict-encrypt	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

subodh1810 · 2022-11-14T08:14:18Z

/publish connector=connectors/source-mysql

🕑 Publishing the following connectors:
connectors/source-mysql
https://github.com/airbytehq/airbyte/actions/runs/3459638979

Connector	Did it publish?	Were definitions generated?
connectors/source-mysql	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

subodh1810 · 2022-11-14T10:05:22Z

/publish connector=connectors/source-mysql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mysql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3460412886

Connector	Did it publish?	Were definitions generated?
connectors/source-mysql-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

….com/airbytehq/airbyte into tiny-int-unsigned-should-not-boolean

…8956) * mysql-source:tinyint-unsigned should not be identified as boolean * upgrade version * fix encrypted spec * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]>

mysql-source:tinyint-unsigned should not be identified as boolean

3ffd629

subodh1810 requested review from rodireich and akashkulk November 4, 2022 08:25

subodh1810 requested a review from a team as a code owner November 4, 2022 08:25

github-actions bot added the area/connectors Connector related issues label Nov 4, 2022

octavia-squidington-iv added the connectors/source/mysql label Nov 4, 2022

subodh1810 self-assigned this Nov 4, 2022

Merge branch 'master' into tiny-int-unsigned-should-not-boolean

e1b02be

akashkulk approved these changes Nov 7, 2022

View reviewed changes

rodireich approved these changes Nov 8, 2022

View reviewed changes

Merge branch 'master' into tiny-int-unsigned-should-not-boolean

7a6ee45

subodh1810 added 2 commits November 14, 2022 13:39

Merge branch 'master' into tiny-int-unsigned-should-not-boolean

28ed631

upgrade version

e0d89f8

octavia-squidington-iv added area/documentation Improvements or additions to documentation connectors/source/mysql-strict-encrypt labels Nov 14, 2022

fix encrypted spec

4b57a49

octavia-squidington-iii added 2 commits November 14, 2022 10:42

auto-bump connector version

f5ea2e7

Merge branch 'tiny-int-unsigned-should-not-boolean' of https://github…

38e7d71

….com/airbytehq/airbyte into tiny-int-unsigned-should-not-boolean

octavia-squidington-iii temporarily deployed to more-secrets November 14, 2022 10:44 Inactive

subodh1810 merged commit 5d2011d into master Nov 14, 2022

subodh1810 deleted the tiny-int-unsigned-should-not-boolean branch November 14, 2022 11:40

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mysql-source:tinyint-unsigned should not be identified as boolean #18956

mysql-source:tinyint-unsigned should not be identified as boolean #18956

subodh1810 commented Nov 4, 2022

subodh1810 commented Nov 4, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Nov 4, 2022 •

edited

Loading

⚠ Sources (2)

✅ Destinations (0)

Actionable Items

subodh1810 commented Nov 7, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 11, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 14, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 14, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 14, 2022 •

edited by github-actions bot

Loading

mysql-source:tinyint-unsigned should not be identified as boolean #18956

mysql-source:tinyint-unsigned should not be identified as boolean #18956

Conversation

subodh1810 commented Nov 4, 2022

subodh1810 commented Nov 4, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Nov 4, 2022 • edited Loading

Affected Connector Report

⚠ Sources (2)

✅ Destinations (0)

Actionable Items

subodh1810 commented Nov 7, 2022 • edited by github-actions bot Loading

Build Passed

subodh1810 commented Nov 11, 2022 • edited by github-actions bot Loading

Build Passed

subodh1810 commented Nov 14, 2022 • edited by github-actions bot Loading

subodh1810 commented Nov 14, 2022 • edited by github-actions bot Loading

subodh1810 commented Nov 14, 2022 • edited by github-actions bot Loading

subodh1810 commented Nov 4, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Nov 4, 2022 •

edited

Loading

subodh1810 commented Nov 7, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 11, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 14, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 14, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 14, 2022 •

edited by github-actions bot

Loading