-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ingress template value #16931
Update ingress template value #16931
Conversation
44503a8
to
9686725
Compare
hi, seeing an api rate limit error when publishing this version, could you take a look? https://github.com/airbytehq/airbyte/actions/runs/3107114369 |
@marcosmarxm when can we release this to resolve the issue as the fix is not deployed to artifact hub. Linked to https://github.com/airbytehq/helm-charts/issues/2 |
@xpuska513 can you check @koconder comment? |
Use $ as the Helm the range macro is used. Co-authored-by: Dusty Shapiro <[email protected]>
Yeah... |
Let me try to run this manually |
FYI: The current workflow does not generate version properly(I'll do this manually for now) |
Use $ as the Helm the range macro is used. Co-authored-by: Dusty Shapiro <[email protected]>
What
If you are deploying Airbyte via Helm chart and decide to override the ingress value in the webapp, you'll receive an error related to this template.
How
Per this issue, it needs to be updated as it's inside a range.
Credit to @as42sl for the fix.
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.