Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress in Helm chart broken #16800

Closed
as42sl opened this issue Sep 16, 2022 · 4 comments
Closed

Ingress in Helm chart broken #16800

as42sl opened this issue Sep 16, 2022 · 4 comments
Labels
area/platform issues related to the platform community helm kubernetes team/prod-eng type/bug Something isn't working

Comments

@as42sl
Copy link

as42sl commented Sep 16, 2022

Activating the ingress breaks the helm chart:

{"level":"error","ts":"2022-09-15T12:52:48.137Z","msg":"reconciliation failed: Helm upgrade failed: template: airbyte/charts/webapp/templates/ingress.yaml:53:33: executing \"airbyte/charts/webapp/templates/ingress.yaml\" at <.Release.Name>: nil pointer evaluating interface {}.Name","name":"airbyte","namespace":"data-warehouse-airbyte","reconciler kind":"HelmRelease","annotations":{"helm.toolkit.fluxcd.io/revision":"0.40.6"}}

Test with: webapp.ingress.enabled: true

It used to work with v '0.41.0'

Here is the culprit: https://github.com/airbytehq/airbyte/blob/master/charts/airbyte-webapp/templates/ingress.yaml#L53
It should be {{ $.Release.Name }} instead of{{ .Release.Name }} because it is inside a range

@DustyShap
Copy link
Contributor

I am also seeing this error, thanks for opening the issue. Do you have a current workaround for latest charts?

@sajarin sajarin removed needs-triage team/tse Technical Support Engineers autoteam labels Sep 19, 2022
@octavia-squidington-iii octavia-squidington-iii added autoteam team/tse Technical Support Engineers labels Sep 19, 2022
@sajarin sajarin added area/platform issues related to the platform kubernetes helm team/prod-eng and removed team/tse Technical Support Engineers autoteam labels Sep 19, 2022
@sajarin
Copy link
Contributor

sajarin commented Sep 19, 2022

Thanks @as42sl for the issue. Are you willing to submit a PR? If not, someone from our team will try to resolve this issue when they're able to. Thanks.

@DustyShap
Copy link
Contributor

I have opened a PR @sajarin , would love some 👁️ on this so I can get Airbyte deployed!

#16931

@sajarin
Copy link
Contributor

sajarin commented Sep 20, 2022

Thanks for the PR @DustyShap, someone will review it soon and we'll get it merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community helm kubernetes team/prod-eng type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants