-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an explicit v0 version of the protocol #16797
Add an explicit v0 version of the protocol #16797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to create a ticket/issue right now to track the symlink switch to v1?
@@ -0,0 +1 @@ | |||
../airbyte_protocol.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Symlinks are rendered like this in github.
@jdpgrailsdev, I created #16814 to track this. |
What
How
Introduce folders with the major version of the protocol.
The new tree would be
For the first iteration,
airbyte_protocol/v0/airbyte_protocol.yaml
is going to be a symlink towards,airbyte_protocol/airbyte_protocol.yaml
.When we add
v1
, we should modifyairbyte_protocol/airbyte_protocol.yaml
to be a symlink towards the most recent version (iev1
).🚨 User Impact 🚨
There should be no impact since the current file remains the source of truth.