Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build the different major versions of the Protocol #15989

Closed
gosusnp opened this issue Aug 25, 2022 · 1 comment
Closed

Build the different major versions of the Protocol #15989

gosusnp opened this issue Aug 25, 2022 · 1 comment
Assignees
@gosusnp
Labels
team/platform-move

Comments

@gosusnp
Copy link
Contributor

gosusnp commented Aug 25, 2022

What

In order for the platform to support different versions of the protocol, we need to modify the build system so that we can have the different versions around at the same time.

How

airbyte-protocol/protocol-models/src/main/resources/airbyte_protocol should have a /v0, /v1 subdirs with the airbyte-protocol.yaml.
We should have a namespaced versions of the messages in the lib.

Open question: should we have everything in one lib or have the lib versioned? (different artifact for each major version)
@gosusnp gosusnp self-assigned this Sep 14, 2022
@gosusnp
Copy link
Contributor Author

gosusnp commented Sep 22, 2022

Done in #16797

@gosusnp gosusnp closed this as completed Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gosusnp gosusnp

Labels
team/platform-move
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gosusnp