Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly add implicit dependencies of acceptance tests #1170

Merged
merged 2 commits into from
Dec 14, 2020
Merged

explicitly add implicit dependencies of acceptance tests #1170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
316e925
explicitly add implicit dependencies of acceptance tests
cgardens Dec 2, 2020
d739f2f
Merge branch 'master' into cgardens/add_acceptance_tests_deps
jrhizor Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion airbyte-tests/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ configurations {

dependencies {
acceptanceTestsImplementation project(':airbyte-api')
acceptanceTestsImplementation project(':airbyte-commons')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought airbyte-commons gets pulled in from the root level project?

acceptanceTestsImplementation project(':airbyte-config:persistence')
acceptanceTestsImplementation project(':airbyte-db')
acceptanceTestsImplementation project(':airbyte-test-utils')
Expand All @@ -45,5 +46,7 @@ task acceptanceTests(type: Test) {
exceptionFormat "full"
}
mustRunAfter test
}

dependsOn ':airbyte-integrations:connectors:source-postgres:airbyteDocker'
dependsOn ':airbyte-integrations:connectors:destination-csv:airbyteDocker'
}