explicitly add implicit dependencies of acceptance tests #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherifnada
approved these changes
Dec 2, 2020
| @@ -25,6 +25,7 @@ configurations { | |||
|
|
|||
| dependencies { | |||
| acceptanceTestsImplementation project(':airbyte-api') | |||
| acceptanceTestsImplementation project(':airbyte-commons') | |||
There was a problem hiding this comment.
I thought airbyte-commons gets pulled in from the root level project?
jrhizor
approved these changes
Dec 2, 2020
|
@jrhizor how does this PR plays with your build changes? |
|
This didn't conflict with my changes at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
source-postgresanddestination-csv. Things kinda worked before because there's always a :dev version of them somewhere, but we should make the dep explicit so that the tests always use a local dev airbyte.airbyte-commons. add the dep explicitly. previously it was getting it transitively. In practice this was annoying because intellij can't find the classes when linting every time.