Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Github: Fix "PAT Credentials" in spec #11678

Merged
merged 4 commits into from
Apr 4, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Apr 2, 2022

Signed-off-by: Sergey Chvalyuk [email protected]

What

Fix regression in spec related to "PAT Credentials" field

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <[email protected]>
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 2, 2022
@grubberr grubberr temporarily deployed to more-secrets April 2, 2022 08:54 Inactive
@grubberr grubberr temporarily deployed to more-secrets April 2, 2022 08:54 Inactive
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr temporarily deployed to more-secrets April 2, 2022 08:58 Inactive
@grubberr grubberr temporarily deployed to more-secrets April 2, 2022 08:58 Inactive
@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@865400e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11678   +/-   ##
=========================================
  Coverage          ?   90.76%           
=========================================
  Files             ?        3           
  Lines             ?      574           
  Branches          ?        0           
=========================================
  Hits              ?      521           
  Misses            ?       53           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865400e...4c38e00. Read the comment docs.

@grubberr grubberr requested review from bazarnov and davydov-d April 2, 2022 09:08
@grubberr grubberr self-assigned this Apr 2, 2022
@grubberr
Copy link
Contributor Author

grubberr commented Apr 2, 2022

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2081600014
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2081600014
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_github/__init__.py       2      0   100%
source_github/streams.py      484     29    94%
source_github/source.py        89     24    73%
-----------------------------------------------
TOTAL                         575     53    91%

@grubberr grubberr requested a review from ChristopheDuong April 2, 2022 15:01
@sherifnada sherifnada removed the request for review from ChristopheDuong April 3, 2022 04:23
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grubberr did you verify that this works locally? Also, how could we prevent this from happening in the future?

@grubberr
Copy link
Contributor Author

grubberr commented Apr 4, 2022

@sherifnada to prevent in future #11703

@grubberr
Copy link
Contributor Author

grubberr commented Apr 4, 2022

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2092087330
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2092087330
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_github/__init__.py       2      0   100%
source_github/streams.py      484     29    94%
source_github/source.py        89     24    73%
-----------------------------------------------
TOTAL                         575     53    91%

@grubberr grubberr temporarily deployed to more-secrets April 4, 2022 19:33 Inactive
@grubberr grubberr temporarily deployed to more-secrets April 4, 2022 19:33 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Apr 4, 2022

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2092241451
❌ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2092241451

@grubberr
Copy link
Contributor Author

grubberr commented Apr 4, 2022

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2092436660
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/2092436660

Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr merged commit 77eca9f into master Apr 4, 2022
@grubberr grubberr deleted the grubberr/11651-source-github branch April 4, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub source : Personal Access Token authentication method fails since version 0.2.23
3 participants