-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAT: check oneOf common property has only const
keyword, no default
and enum
keywords
#11703
Labels
type/bug
Something isn't working
Comments
grubberr
changed the title
SAT: improve test_oneof_usage common_prop
SAT: improve test_oneof_usage common_prop Apr 4, 2022
const
equal default
const
equals default
16 tasks
16 tasks
@grubberr cant we just use const keyword always instead of adding the enum and default keywords? |
@sherifnada I just checked, I see we have 2 option:
or
What is better (a) or (b) ? What do you think ? |
I think 1 is better, because it makes the iface simpler for the user |
oustynova
moved this from Implementation in progress
to In review (internal)
in GL Roadmap
Apr 6, 2022
grubberr
changed the title
SAT: improve test_oneof_usage common_prop
SAT: check oneOf common property has only Apr 6, 2022
const
equals default
const
keyword, no default
and enum
keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to improve SAT
test_oneof_usage
to check that common oneOf property looks like this:only
const
keywordNO MORE
default
andenum
keywords.old value
The text was updated successfully, but these errors were encountered: