Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Websocket pxd create debug windows #9546

Closed
wants to merge 69 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
689536f
Seperate http_websocket into multiple files
bdraco Oct 26, 2024
de38d0c
Seperate http_websocket into multiple files
bdraco Oct 26, 2024
49150fe
Seperate http_websocket into multiple files
bdraco Oct 26, 2024
3121b6d
Seperate http_websocket into multiple files
bdraco Oct 26, 2024
fc598bc
fix location
bdraco Oct 26, 2024
ae26d08
more cleanups
bdraco Oct 26, 2024
dcc924e
keep compat
bdraco Oct 26, 2024
18752e8
Add pxd file for _websocket_reader
bdraco Oct 26, 2024
05696fb
Test building from pxd
bdraco Oct 26, 2024
975e80b
subclass to allow patching
bdraco Oct 26, 2024
9164179
more cleanups
bdraco Oct 26, 2024
106adcb
more types
bdraco Oct 26, 2024
4717a06
more types
bdraco Oct 26, 2024
68acafc
type cleanups
bdraco Oct 26, 2024
133b50c
changelog
bdraco Oct 26, 2024
0fc268e
Relocate to _websocket
bdraco Oct 27, 2024
33149b0
fix path
bdraco Oct 27, 2024
26ae66f
Merge branch 'websocket_pxd' into websocket_pxd_create
bdraco Oct 27, 2024
ddd73db
fix patch target
bdraco Oct 27, 2024
f6a76f9
Merge branch 'websocket_pxd' into websocket_pxd_create
bdraco Oct 27, 2024
e077a36
rework so NO_EXTENSIONS is considered
bdraco Oct 27, 2024
b74b874
namespace cleanups
bdraco Oct 27, 2024
6e0fdcb
Revert "namespace cleanups"
bdraco Oct 27, 2024
5fb55e8
Merge branch 'websocket_pxd' into websocket_pxd_create
bdraco Oct 27, 2024
439101c
fix build path
bdraco Oct 27, 2024
8cda99a
add missing pxd file for mask
bdraco Oct 27, 2024
3b690f5
fix some double conversion
bdraco Oct 27, 2024
b6d256a
objects are immutable
bdraco Oct 27, 2024
d8d3c3a
match defs since we use the cython code insidepython code
bdraco Oct 27, 2024
f05f3bf
naming
bdraco Oct 27, 2024
9d9a886
Merge branch 'master' into websocket_pxd_create
bdraco Oct 27, 2024
9fb530d
must be named reader_c because PyInit is named
bdraco Oct 27, 2024
7fed656
reduce makefile
bdraco Oct 27, 2024
34acf92
fix namespace
bdraco Oct 27, 2024
df1e219
namespace fix
bdraco Oct 27, 2024
097899f
fix type, its not base exception
bdraco Oct 27, 2024
2be1609
reduce opcode type to unsigned int
bdraco Oct 27, 2024
3697714
reduce opcode type to unsigned int
bdraco Oct 27, 2024
54dab0a
lint
bdraco Oct 27, 2024
c03fde4
fix type
bdraco Oct 27, 2024
e3ecce8
changelog
bdraco Oct 27, 2024
55b6ad2
Update aiohttp/_websocket/reader_py.py
bdraco Oct 27, 2024
ffba3db
Revert "fix type"
bdraco Oct 27, 2024
0f9bea9
Revert "lint"
bdraco Oct 27, 2024
4ae06ce
Revert "reduce opcode type to unsigned int"
bdraco Oct 27, 2024
f1c83a0
Revert "reduce opcode type to unsigned int"
bdraco Oct 27, 2024
4ad464a
Merge remote-tracking branch 'upstream/websocket_pxd_create' into web…
bdraco Oct 27, 2024
6432c93
no need to convert it since its being packed into a tuple
bdraco Oct 27, 2024
d194295
cleanup type on masking
bdraco Oct 27, 2024
f101ef1
cleanup signature on mask
bdraco Oct 27, 2024
35100b6
cleanup signature on _feed_data
bdraco Oct 27, 2024
e24344f
Debug websocket reader cython implementation on windows
bdraco Oct 27, 2024
912f895
wrap in timeout
bdraco Oct 27, 2024
5cecc8c
Revert "wrap in timeout"
bdraco Oct 27, 2024
c3a856a
debug with timeout
bdraco Oct 27, 2024
4f0cd4d
Revert "debug with timeout"
bdraco Oct 27, 2024
111e161
disable ext for testing
bdraco Oct 27, 2024
fb97412
run single test
bdraco Oct 27, 2024
6f4b3c3
run single test
bdraco Oct 27, 2024
e85aecb
Revert "disable ext for testing"
bdraco Oct 27, 2024
0fafaf0
check if its the pxd
bdraco Oct 27, 2024
bccdef5
Revert "check if its the pxd"
bdraco Oct 27, 2024
ac1ff4f
... debug prints?
bdraco Oct 27, 2024
4aed18d
raw debug
bdraco Oct 27, 2024
df6d6a0
prints
bdraco Oct 27, 2024
3eb183e
handle data not being bytes
bdraco Oct 27, 2024
6d7e29d
handle data not being bytes
bdraco Oct 27, 2024
107fb26
return types
bdraco Oct 27, 2024
4e4c14d
Merge branch 'websocket_pxd_create' into websocket_pxd_create_debug_w…
bdraco Oct 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wrap in timeout
  • Loading branch information
bdraco committed Oct 27, 2024
commit 912f895f722ede8d5b239a71fca7c6427e36c2ae
21 changes: 11 additions & 10 deletions tests/test_client_ws_functional.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,20 @@ async def handler(request: web.Request) -> web.WebSocketResponse:
await ws.close()
return ws

app = web.Application()
app.router.add_route("GET", "/", handler)
client = await aiohttp_client(app)
resp = await client.ws_connect("/")
await resp.send_str("ask")
async with asyncio.timeout(10):
app = web.Application()
app.router.add_route("GET", "/", handler)
client = await aiohttp_client(app)
resp = await client.ws_connect("/")
await resp.send_str("ask")

assert resp.get_extra_info("socket") is not None
assert resp.get_extra_info("socket") is not None

data = await resp.receive_str()
assert data == "ask/answer"
await resp.close()
data = await resp.receive_str()
assert data == "ask/answer"
await resp.close()

assert resp.get_extra_info("socket") is None
assert resp.get_extra_info("socket") is None


async def test_send_recv_bytes_bad_type(aiohttp_client: AiohttpClient) -> None:
Expand Down
Loading