Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM: Websocket pxd create debug windows #9546

Closed
wants to merge 69 commits into from
Closed

DNM: Websocket pxd create debug windows #9546

wants to merge 69 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 27, 2024 •
edited
Loading

#9543 is stalling the CI on windows with python 3.10 and 3.11 only with no obvious reason

bdraco added 30 commits October 26, 2024 09:36
@bdraco
Seperate http_websocket into multiple files
689536f 
There are not functional changes here. The goal is to be able to
able to make it easier to build a Cython implementation for the
WebsocketReader
@bdraco
Seperate http_websocket into multiple files
de38d0c 
There are not functional changes here. The goal is to be able to
able to make it easier to build a Cython implementation for the
WebsocketReader
@bdraco
Seperate http_websocket into multiple files
49150fe 
There are not functional changes here. The goal is to be able to
able to make it easier to build a Cython implementation for the
WebsocketReader
@bdraco
Seperate http_websocket into multiple files
3121b6d 
There are not functional changes here. The goal is to be able to
able to make it easier to build a Cython implementation for the
WebsocketReader
@bdraco
fix location
fc598bc
@bdraco
more cleanups
ae26d08
@bdraco
keep compat
dcc924e
@bdraco
Add pxd file for _websocket_reader
18752e8
@bdraco
Test building from pxd
05696fb
@bdraco
subclass to allow patching
975e80b
@bdraco
more cleanups
9164179
@bdraco
more types
106adcb
@bdraco
more types
4717a06
@bdraco
type cleanups
68acafc
@bdraco
changelog
133b50c
@bdraco
Relocate to _websocket
0fc268e
@bdraco
fix path
33149b0
@bdraco
Merge branch 'websocket_pxd' into websocket_pxd_create
26ae66f
@bdraco
fix patch target
ddd73db
@bdraco
Merge branch 'websocket_pxd' into websocket_pxd_create
f6a76f9
@bdraco
rework so NO_EXTENSIONS is considered
e077a36
@bdraco
namespace cleanups
b74b874
@bdraco
Revert "namespace cleanups"
6e0fdcb 
This reverts commit b74b874.
@bdraco
Merge branch 'websocket_pxd' into websocket_pxd_create
5fb55e8
@bdraco
fix build path
439101c
@bdraco
add missing pxd file for mask
8cda99a
@bdraco
fix some double conversion
3b690f5
@bdraco
objects are immutable
b6d256a
@bdraco
match defs since we use the cython code insidepython code
d8d3c3a
@bdraco
naming
f05f3bf
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 27, 2024
@bdraco bdraco changed the title Websocket pxd create debug windows DNM: Websocket pxd create debug windows Oct 27, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 27, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9546 will improve performances by 91.3%

Comparing websocket_pxd_create_debug_windows (df6d6a0) with master (dd9a1fd)

Summary

⚡ 1 improvements
✅ 3 untouched benchmarks

Benchmarks breakdown

Benchmark master websocket_pxd_create_debug_windows Change
⚡ test_read_one_hundred_websocket_text_messages[pyloop] 1,295.4 µs 677.1 µs +91.3%

@codecov Codecov
Copy link

codecov bot commented Oct 27, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3288 1 3287 56
View the top 1 failed tests by shortest run time 
tests.test_client_ws_functional test_send_recv_text[pyloop]
Stack Traces | 0.077s run time 
aiohttp_client = <function aiohttp_client.<locals>.go at 0x000001CE46E91EE0>

    #x1B[0m#x1B[94masync#x1B[39;49;00m #x1B[94mdef#x1B[39;49;00m #x1B[92mtest_send_recv_text#x1B[39;49;00m(aiohttp_client: AiohttpClient) -> #x1B[94mNone#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
        #x1B[94masync#x1B[39;49;00m #x1B[94mdef#x1B[39;49;00m #x1B[92mhandler#x1B[39;49;00m(request: web.Request) -> web.WebSocketResponse:#x1B[90m#x1B[39;49;00m
            ws = web.WebSocketResponse()#x1B[90m#x1B[39;49;00m
            #x1B[94mawait#x1B[39;49;00m ws.prepare(request)#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
            msg = #x1B[94mawait#x1B[39;49;00m ws.receive_str()#x1B[90m#x1B[39;49;00m
            #x1B[94mawait#x1B[39;49;00m ws.send_str(msg + #x1B[33m"#x1B[39;49;00m#x1B[33m/answer#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
            #x1B[94mawait#x1B[39;49;00m ws.close()#x1B[90m#x1B[39;49;00m
            #x1B[94mreturn#x1B[39;49;00m ws#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
>       #x1B[94masync#x1B[39;49;00m #x1B[94mwith#x1B[39;49;00m asyncio.timeout(#x1B[94m10#x1B[39;49;00m):#x1B[90m#x1B[39;49;00m
#x1B[1m#x1B[31mE       AttributeError: module 'asyncio' has no attribute 'timeout'#x1B[0m

aiohttp_client = <function aiohttp_client.<locals>.go at 0x000001CE46E91EE0>
handler    = <function test_send_recv_text.<locals>.handler at 0x000001CE46E91820>

#x1B[1m#x1B[31mtests\test_client_ws_functional.py#x1B[0m:30: AttributeError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 27, 2024
View reviewed changes
test_app.py
import asyncio
import pprint

import aiohttp

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note test

Module 'aiohttp' is imported with both 'import' and 'import from'.
test_app.py
if msg.data == "close":
break
await ws.send_str(msg)
except (Exception, asyncio.CancelledError):

Check notice

Code scanning / CodeQL

Empty except Note test

'except' clause does nothing but pass and there is no explanatory comment.
@bdraco
Copy link
Member Author

bdraco commented Oct 27, 2024

protractor on 3.10 and 3.11 :(

TypeError: Argument 'data' has incorrect type (expected bytes, got bytearray)

@bdraco
Copy link
Member Author

bdraco commented Oct 27, 2024

So the type is wrong elsewhere as well

@bdraco bdraco closed this Oct 27, 2024
@bdraco bdraco deleted the websocket_pxd_create_debug_windows branch October 27, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz will be requested when the pull request is marked ready for review webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov will be requested when the pull request is marked ready for review asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco