Add --update and --watch options #4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,9 @@ | |
| }, | ||
| "dependencies": { | ||
| "chalk": "^3.0.0", | ||
| "chokidar": "^3.3.1", | ||
| "globby": "^11.0.0", | ||
| "parse-gitignore": "^1.0.1" | ||
| }, | ||
| "author": "Andrey Sitnik <[email protected]>", | ||
| "license": "MIT", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| let { spawn } = require('child_process') | ||
| let chalk = require('chalk') | ||
|
|
||
| let showSnapshots = require('./show-snapshots') | ||
|
|
||
| async function updateAndShowSnaphots (print, cwd, filter) { | ||
| print(chalk.blue('\nUpdating snapshots... \n')) | ||
|
|
||
|
|
||
| let spawned = spawn('npx', ['jest', '-u'], { | ||
| cwd, stdio: 'inherit' | ||
| }) | ||
|
|
||
| spawned.on('exit', async () => { | ||
|
There was a problem hiding this comment. Why do we need |
||
| print(chalk.green('\nSnapshots updated! \n')) | ||
|
|
||
|
|
||
| await showSnapshots(print, cwd, filter) | ||
| }) | ||
| } | ||
|
|
||
| module.exports = updateAndShowSnaphots | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| let fs = require('fs') | ||
| let chokidar = require('chokidar') | ||
| let parseGitignore = require('parse-gitignore') | ||
|
|
||
| let updateAndShowSnaphots = require('./update-and-show-snapshots') | ||
|
|
||
| async function watchAndShowSnaphots (print, cwd, filter) { | ||
| let ignored = ['.git', 'node_modules'] | ||
|
|
||
| if (fs.existsSync(`${ cwd }/.gitignore`)) { | ||
| ignored = [...new Set([ | ||
| ...ignored, | ||
| ...parseGitignore(fs.readFileSync(`${ cwd }/.gitignore`)).map( | ||
|
There was a problem hiding this comment. We can believe that The only way to find the project root is to find |
||
| p => /\/$/.test(p) ? p.replace(/\/$/, '') : p | ||
| ) | ||
| ])] | ||
| } | ||
|
|
||
| let watcher = chokidar.watch('**/*.js', { | ||
| cwd, ignored | ||
| }) | ||
|
|
||
| return watcher | ||
| .on('change', async () => { | ||
| await updateAndShowSnaphots(print, cwd, filter) | ||
| }) | ||
| } | ||
|
|
||
| module.exports = watchAndShowSnaphots | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filter can be passed before
--updateThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are shure about give ability to set filter before args?
For example, all CLIs that working with paths accept it as last argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap. User may call
npx print-snapshots server, found problem, press arrow up to load latest command in terminal and add--watchin the end.By the way, did we forget about changing
--help?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, i will fix it and update help output. Thank you!