Add --update and --watch options #4

LordotU · 2020-02-20T11:37:05Z

No description provided.

ai · 2020-02-20T17:09:48Z

@LordotU Why did you choose chokidar? What other alternatives we have? What is the difference between them?

ai · 2020-02-20T17:15:30Z

package.json

@@ -61,5 +63,8 @@
      "CLI",
      "backtick"
    ]
+  },
+  "peerDependencies": {


It is better to create separate PR for another changes

ai · 2020-02-20T17:17:04Z

update-and-show-snapshots.js

+async function updateAndShowSnaphots (print, error, cwd, filter) {
+  print(chalk.blue('\nUpdating snapshots... \n'))
+
+  let { stdout, stderr } = await execCommand('"./node_modules/.bin/jest" -u', {


npx jest --no-install is a better way since we can’t trust to find jest in ./node_modules/.bin/.

For instance, we print-snapshots can be run from ./test dir. In this case ./node_modules/.bin/jest will not be found.

ai · 2020-02-20T17:18:00Z

update-and-show-snapshots.js

+    cwd
+  })
+
+  print(chalk.grey(stdout))


Here you will lose Jest color output. We need to keep origin colors, because jest -u can fall and colors will help us to find the reasons.

In Node.js we have std: inherit option to bind executed script to existed stdout/stderr. In this case you will not loose colors.

bin.js

LordotU · 2020-02-20T19:17:39Z

@LordotU Why did you choose chokidar? What other alternatives we have? What is the difference between them?

Hi!

Chokidar is very hyped, yes, but I think it is the most maintainable package with pretty API, anymatch pattern support and short graph of deps. Also we have, for example:

https://www.npmjs.com/package/node-watch (no words about glob/anymatch)
https://www.npmjs.com/package/watchr (weird API)

and some others, that were updated a year ago

ai · 2020-02-20T19:25:52Z

What about webpack’s watchpack?

LordotU · 2020-02-20T19:42:10Z

What about webpack’s watchpack?

When I searched, this package was not even on the second page, cause my query was fs watch , not file watch.
By the way, there is an interesting issue webpack/watchpack#130.
Also, as I understand, watchpack try to watch all files instead of ignored?
If you have a positive usage expirience of it's usage - ok. I've used only chokidar and node-watch

ai · 2020-02-20T20:35:36Z

bin.js

+
+  if (arg === '--watch') {
+    (await watchAndShowSnaphots(print, error, cwd, filter))
+      .on('error', err => error(err.stack || err))


Let’s refactor this code to something more readable. We even pass error function there, we do not need to print errors here.

ai · 2020-02-20T20:37:22Z

By the way, there is an interesting issue webpack/watchpack#130.

Yeap. I prefer smaller dependency

ai · 2020-02-20T20:45:40Z

update-and-show-snapshots.js

-
-  print(chalk.green('Snapshots updated! \n'))
+  spawned.on('exit', async () => {
+    print(chalk.green('\nSnapshots updated! \n'))


I think we do not need this note

LordotU · 2020-02-20T20:51:44Z

By the way, there is an interesting issue webpack/watchpack#130.

Yeap. I prefer smaller dependency

https://npm.anvaka.com/#/view/2d/watchpack vs https://npm.anvaka.com/#/view/2d/chokidar

Chokidar is the winner? )

ai · 2020-02-20T20:54:50Z

Yeap, let’s use chokidar

ai · 2020-02-20T20:55:48Z

update-and-show-snapshots.js

+let showSnapshots = require('./show-snapshots')
+
+async function updateAndShowSnaphots (print, cwd, filter) {
+  print(chalk.blue('\nUpdating snapshots... \n'))


Let’s remove this note as well

ai · 2020-02-20T20:56:47Z

watch-and-show-snapshots.js

+  if (fs.existsSync(`${ cwd }/.gitignore`)) {
+    ignored = [...new Set([
+      ...ignored,
+      ...parseGitignore(fs.readFileSync(`${ cwd }/.gitignore`)).map(


We can believe that cwd will be the root of the project (since the user can run tool from test/ dir)

The only way to find the project root is to find package.json.

ai · 2020-02-20T20:58:32Z

bin.js

@@ -16,16 +20,22 @@ function print (...lines) {

 async function run () {
  let arg = process.argv[2] || ''
+  let filter = process.argv[3] || ''


The filter can be passed before --update

Are shure about give ability to set filter before args?
For example, all CLIs that working with paths accept it as last argument

Yeap. User may call npx print-snapshots server, found problem, press arrow up to load latest command in terminal and add --watch in the end.

By the way, did we forget about changing --help?

Ok, i will fix it and update help output. Thank you!

ai · 2020-02-20T20:59:38Z

update-and-show-snapshots.js

+    cwd, stdio: 'inherit'
+  })
+
+  spawned.on('exit', async () => {


Why do we need async here? exit callback can’t return a Promise

ai · 2020-02-20T21:34:08Z

watch-and-show-snapshots.js

 let chokidar = require('chokidar')
 let parseGitignore = require('parse-gitignore')

 let updateAndShowSnaphots = require('./update-and-show-snapshots')

+let rootPath = path.dirname(require.main.filename)


require.main.filename will point to /path/to/the/project/node_modules/.bin/print-snapshots.

I think we need pkg-up to find package.json and be sure about the root of the project.

It seems, I need to sleep a little :-)

…rsing

LordotU · 2020-02-21T18:07:19Z

@ai Thanks for the tips. I was glad to help!

ai · 2020-02-21T18:30:28Z

Do you have a Twitter account?

ai · 2020-02-21T18:31:18Z

Released at 0.2

LordotU · 2020-02-21T18:56:38Z

Do you have a Twitter account?

The same as Github - https://twitter.com/LordotU.
It's abandoned and now I'm using it just for reading my feed. )

feat: Add --update and --watch options

cad21c4

LordotU force-pushed the feat/watch-and-update branch from 63ffa55 to cad21c4 Compare February 20, 2020 15:14

fix: Mixed up methods

f234880