-
Notifications
You must be signed in to change notification settings - Fork 306
Add Tool Choice parameter to model provider configs for tool control #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One thing of note, doing this actually forces models to not output any other tokens besides the tool call, so a model can no longer do reasoning for tool calls, the assistant's reply is pre-filled with the beginning of the tool call basically.
|
Thanks @alecsolder, I'll add this to the documentation, definitely a trade-off. |
Codecov ReportAttention: Patch coverage is
... and 65 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Big thank you for this! This is hugely important and combined with vllm getting support for this in its next release, we are in for a renaissance in local AI agents. |
Thanks @Hellisotherpeople! Love local models and, therefore, local agents :) |
Why are these changes needed?
Model providers typically provide a means, through their parameters, to force tool calls (and force no tool calls).
This PR adds this parameter to the model provider LLMConfigs we have and documentation to demonstrate how to use it.
Thanks to @alecsolder for inspiration on their reliable function calling (#927).
Related issue number
N/A
Checks