Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Workaround for #4567 (Dialog text renders poorly on Windows) #4955

Merged
merged 2 commits into from
Aug 27, 2013

Conversation

peterflynn
Copy link
Member

Workaround for bug #4567 (Dialog text renders poorly on Windows): Fix the worst offenders similar to #4554, making the font weight heavier and tweaking the text color to match Mac more closely. Generalized the original fix into a reusable mixin.

… the

worst offenders similar to #4554, making the font weight heavier and
tweaking the text color to match Mac more closely.
@peterflynn
Copy link
Member Author

@larz0 What do you think? This is basically the same adjustment as in #4554, but in several more parts of the UI...

New appearance:
fixed-about
vs. appearance on master:
master-about

New appearance:
fixed-messagedialog
vs. appearance on master:
master-messagedialog

The project settings dialog is unaffected because it was already font-weight: normal (probably unintentional due to a Bootstrap rule getting higher specificity, but it works in our favor this time).

@ghost ghost assigned JeffryBooher Aug 27, 2013
@JeffryBooher
Copy link
Contributor

Looks good. Merging

JeffryBooher added a commit that referenced this pull request Aug 27, 2013
Workaround for #4567 (Dialog text renders poorly on Windows)
@JeffryBooher JeffryBooher merged commit a049c6c into master Aug 27, 2013
@JeffryBooher JeffryBooher deleted the pflynn/dialog-font-win branch August 27, 2013 18:10
@njx
Copy link

njx commented Aug 27, 2013

@larz0 - we went ahead and merged this since it definitely makes the text more legible, it's the end of the sprint and you're at XD Shark Week. If we need to tweak it further next sprint that's cool.

@larz0
Copy link
Member

larz0 commented Aug 28, 2013

@njx ok cool. It's so much better from @peterflynn's screenshots.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants