Applied Typographic Tweaks #4930
Conversation
|
@peterflynn could you take a look? (CC'ing @njx as well) |
|
@larz0 The font weight changes are interesting, because they essentially encompass the Windows font "faintness" fix from #4955. But in bumping up the font-weight to normal on Mac too, we'll see a disconnect again where the font looks heavier on Mac and lighter on Win. (We won't have the readability issues on Win, though -- that only seems to occur with the lightest weight). I'm also curious about the antialiasing change at the end of the diff. Is that a trick to tweak the apparent font-weight further? Does it work the same on Retina Mac, non-Retina Mac, and Win? |
|
@peterflynn As discussed. I used "-webkit-font-smoothing: antialiased" to make sure that "font-weight: normal" looks somewhere between light and normal, as opposed to the default look of normal which uses subpixel-antialiased instead (slightly fuzzier). |
ghost
assigned
|
@peterflynn yes this is still need for better legibility. I've cleaned up the code so it should be good to merge. |
|
Ping - this would be good to merge soon. |
…eaks * origin/master: (256 commits) Code review cleanups Expose code inspection providers for the extensions. Update to decompress-zip that includes fix for our issue. Code review: use more consts in Find; remove unneeded single-tickmark API hasNativeMenus param code cleanup code cleanup Less bright. First pass. When switching documents from QuickOpen, pop the modal bar out before switching and animate after Amend PR #5311 with an comment and issue ref. Return the result of calling the original jquery focus() function only need to handle closeOk and close events Add code to consistently delete the temporary extraction directory during install. Added .jsm extension for Mozilla JavaScript Module support API changes Change code to use temp package for temp file generation Change from "tmp" to "temp" for temporary stream creation Add console logging for unknown error. fix whitespace clear highlights and Find selection color when modal bar closes ... Conflicts: src/styles/brackets_patterns_override.less
|
I've merged this up with master so it's easier to test |
|
@larz0 Couple things I'm noticing...
|
|
@peterflynn I've fixed the things you mentioned. Made the input less heavier but made the text color black. |
heavier across the board.
Applied Typographic Tweaks - normalize font weights across platforms, removing now-unneeded Win workaround
|
Thanks @peterflynn sounds good. |
This is related to #4912.