Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add proper self-signed cert tests (with proxy option rejectUnauthorized) #70

Merged
merged 4 commits into from
Nov 13, 2024
Merged

fix: add proper self-signed cert tests (with proxy option rejectUnauthorized) #70

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1e67ef
fix: add proper self-signed cert tests (with proxy option rejectUnaut…
shazron Nov 12, 2024
7a180fc
temp: update @adobe/aio-lib-test-proxy to PR branch version. To be re…
shazron Nov 13, 2024
a90ee46
Revert "temp: update @adobe/aio-lib-test-proxy to PR branch version. …
shazron Nov 13, 2024
72cb103
chore(dev-deps): update @adobe/aio-lib-test-proxy to v2.1.0
shazron Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"deprecated": false,
"description": "Adobe I/O Lib Core Networking",
"devDependencies": {
"@adobe/aio-lib-test-proxy": "^1.0.0",
"@adobe/aio-lib-test-proxy": "github:adobe/aio-lib-test-proxy#story/ACNA-3241",
"@adobe/eslint-config-aio-lib-config": "^2.0.1",
"babel-runtime": "^6.26.0",
"dotenv": "^16.3.1",
Expand Down
152 changes: 106 additions & 46 deletions test/proxy.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,14 +189,15 @@ describe('http proxy', () => {
})
})

describe('https proxy', () => {
describe('https proxy (self-signed)', () => {
const protocol = 'https'
let proxyServer, apiServer
const portNotInUse = 3009
const selfSigned = true

describe('no auth', () => {
beforeAll(async () => {
proxyServer = await createHttpsProxy()
proxyServer = await createHttpsProxy({ selfSigned })
apiServer = await createApiServer({ port: 3001, useSsl: true })
})

Expand All @@ -212,29 +213,48 @@ describe('https proxy', () => {
const testUrl = `${protocol}://localhost:${apiServerAddress.port}/mirror?${queryString.stringify(queryObject)}`

const proxyUrl = proxyServer.url
const proxyFetch = new ProxyFetch({ proxyUrl, rejectUnauthorized: false })
const response = await proxyFetch.fetch(testUrl)
// IGNORE self-signed cert errors
{
const proxyFetch = new ProxyFetch({ proxyUrl, rejectUnauthorized: false })
const response = await proxyFetch.fetch(testUrl)

const json = await response.json()
expect(json).toStrictEqual(queryObject)
const json = await response.json()
expect(json).toStrictEqual(queryObject)
}
// DO NOT ignore self-signed cert errors
{
const proxyFetch = new ProxyFetch({ proxyUrl, rejectUnauthorized: true })
await expect(async () => {
await proxyFetch.fetch(testUrl)
}).rejects.toThrow('self-signed certificate in certificate chain')
}
})

test('failure', async () => {
test('failure (non-existent port)', async () => {
// connect to non-existent server port
const testUrl = `${protocol}://localhost:${portNotInUse}/mirror/?foo=bar`

const proxyUrl = proxyServer.url
const proxyFetch = new ProxyFetch({ proxyUrl, rejectUnauthorized: false })

const response = await proxyFetch.fetch(testUrl)
expect(response.ok).toEqual(false)
expect(response.status).toEqual(502)
// IGNORE self-signed cert errors
{
const proxyFetch = new ProxyFetch({ proxyUrl, rejectUnauthorized: false })
const response = await proxyFetch.fetch(testUrl)
expect(response.ok).toEqual(false)
expect(response.status).toEqual(502)
}
// DO NOT ignore self-signed cert errors
{
const proxyFetch = new ProxyFetch({ proxyUrl, rejectUnauthorized: true })
await expect(async () => {
await proxyFetch.fetch(testUrl)
}).rejects.toThrow('self-signed certificate in certificate chain')
}
})
})

describe('basic auth', () => {
beforeAll(async () => {
proxyServer = await createHttpsProxy({ useBasicAuth: true })
proxyServer = await createHttpsProxy({ useBasicAuth: true, selfSigned })
apiServer = await createApiServer({ port: 3001, useSsl: true })
})

Expand All @@ -253,17 +273,28 @@ describe('https proxy', () => {
'Proxy-Authorization': 'Basic ' + Buffer.from(`${username}:${password}`).toString('base64')
}
const proxyUrl = proxyServer.url
const proxyFetch = new ProxyFetch({ proxyUrl, username, password, rejectUnauthorized: false })

const testUrl = `${protocol}://localhost:${apiServerPort}/mirror?${queryString.stringify(queryObject)}`
const response = await proxyFetch.fetch(testUrl, { headers })
const spy = jest.spyOn(proxyFetch, 'fetch').mockImplementation(() => testUrl)
const pattern = /\b^https\b/
expect(proxyFetch.fetch()).toMatch(new RegExp(pattern))
spy.mockRestore()
expect(response.ok).toEqual(true)
const json = await response.json()
expect(json).toStrictEqual(queryObject)
// IGNORE self-signed cert errors
{
const proxyFetch = new ProxyFetch({ proxyUrl, username, password, rejectUnauthorized: false })
const response = await proxyFetch.fetch(testUrl, { headers })

const spy = jest.spyOn(proxyFetch, 'fetch').mockImplementation(() => testUrl)
const pattern = /\b^https\b/
expect(proxyFetch.fetch()).toMatch(new RegExp(pattern))
spy.mockRestore()

expect(response.ok).toEqual(true)
const json = await response.json()
expect(json).toStrictEqual(queryObject)
}
// DO NOT ignore self-signed cert errors
{
const proxyFetch = new ProxyFetch({ proxyUrl, rejectUnauthorized: true })
await expect(async () => {
await proxyFetch.fetch(testUrl)
}).rejects.toThrow('self-signed certificate in certificate chain')
}
})

test('failure', async () => {
Expand All @@ -276,22 +307,33 @@ describe('https proxy', () => {
'Proxy-Authorization': 'Basic ' + Buffer.from(`${username}:${password}`).toString('base64')
}
const proxyUrl = proxyServer.url
const proxyFetch = new ProxyFetch({ proxyUrl, username, password, rejectUnauthorized: false })

const testUrl = `${protocol}://localhost:${apiServerPort}/mirror?${queryString.stringify(queryObject)}`
const response = await proxyFetch.fetch(testUrl, { headers })
const spy = jest.spyOn(proxyFetch, 'fetch').mockImplementation(() => testUrl)
const pattern = /\b^http\b/
expect(proxyFetch.fetch()).not.toMatch(new RegExp(pattern))
spy.mockRestore()
expect(response.ok).toEqual(false)
expect(response.status).toEqual(403)
// IGNORE self-signed cert errors
{
const proxyFetch = new ProxyFetch({ proxyUrl, username, password, rejectUnauthorized: false })
const response = await proxyFetch.fetch(testUrl, { headers })

const spy = jest.spyOn(proxyFetch, 'fetch').mockImplementation(() => testUrl)
const pattern = /\b^http\b/
expect(proxyFetch.fetch()).not.toMatch(new RegExp(pattern))
spy.mockRestore()

expect(response.ok).toEqual(false)
expect(response.status).toEqual(403)
}
// DO NOT ignore self-signed cert errors
{
const proxyFetch = new ProxyFetch({ proxyUrl, rejectUnauthorized: true })
await expect(async () => {
await proxyFetch.fetch(testUrl)
}).rejects.toThrow('self-signed certificate in certificate chain')
}
})
})

describe('HttpExponentialBackoff', () => {
beforeAll(async () => {
proxyServer = await createHttpsProxy()
proxyServer = await createHttpsProxy({ selfSigned })
apiServer = await createApiServer({ port: 3001, useSsl: true })
})

Expand All @@ -306,27 +348,45 @@ describe('https proxy', () => {

const testUrl = `${protocol}://localhost:${apiServerPort}/mirror?${queryString.stringify(queryObject)}`
const proxyUrl = proxyServer.url

const fetchRetry = new HttpExponentialBackoff()
const response = await fetchRetry.exponentialBackoff(testUrl, { method: 'GET' }, {
proxy: { proxyUrl, rejectUnauthorized: false }
})
const json = await response.json()
expect(json).toStrictEqual(queryObject)

// IGNORE self-signed cert errors
{
const response = await fetchRetry.exponentialBackoff(testUrl, { method: 'GET' }, {
proxy: { proxyUrl, rejectUnauthorized: false }
})
const json = await response.json()
expect(json).toStrictEqual(queryObject)
}
// DO NOT ignore self-signed cert errors
await expect(async () => {
return fetchRetry.exponentialBackoff(testUrl, { method: 'GET' }, {
proxy: { proxyUrl, rejectUnauthorized: true }
})
}).rejects.toThrow('self-signed certificate in certificate chain')
})

test('failure', async () => {
// connect to non-existent server port
const testUrl = `${protocol}://localhost:3009/mirror/?foo=bar`
const proxyUrl = proxyServer.url

const fetchRetry = new HttpExponentialBackoff()
const response = await fetchRetry.exponentialBackoff(testUrl, { method: 'GET' }, {
proxy: { proxyUrl, rejectUnauthorized: false },
maxRetries: 2
}, [], 0) // retryDelay must be zero for test timings
expect(response.ok).toEqual(false)
expect(response.status).toEqual(502)

// IGNORE self-signed cert errors
{
const response = await fetchRetry.exponentialBackoff(testUrl, { method: 'GET' }, {
proxy: { proxyUrl, rejectUnauthorized: false },
maxRetries: 2
}, [], 0) // retryDelay must be zero for test timings
expect(response.ok).toEqual(false)
expect(response.status).toEqual(502)
}
// DO NOT ignore self-signed cert errors
await expect(async () => {
return fetchRetry.exponentialBackoff(testUrl, { method: 'GET' }, {
proxy: { proxyUrl, rejectUnauthorized: true }
})
}).rejects.toThrow('self-signed certificate in certificate chain')
})
})
})