Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add proper self-signed cert tests (with proxy option rejectUnauthorized) #70

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

shazron
Copy link
Member

@shazron shazron commented Nov 12, 2024

⚠️ needs new @adobe/aio-lib-test-proxy release with this PR: adobe/aio-lib-test-proxy#7

How Has This Been Tested?

  • npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…horized)

needs new @adobe/aio-lib-test-proxy release
@shazron shazron marked this pull request as ready for review November 13, 2024 07:36
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (458fe01) to head (72cb103).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          135       135           
  Branches        31        31           
=========================================
  Hits           135       135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron merged commit 6ce8e1c into master Nov 13, 2024
8 checks passed
@shazron shazron deleted the self-signed-tests branch November 13, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants