Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/145 Automated aria heading levels #230

Merged
merged 1 commit into from
Jul 4, 2022
Merged

issue/145 Automated aria heading levels #230

merged 1 commit into from
Jul 4, 2022

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jun 21, 2022 •
edited
Loading

part of adaptlearning/adapt-contrib-core#145

Changed

  • a11y_attrs_heading to a11y_aria_level

requires adaptlearning/adapt-contrib-core#146

@oliverfoster oliverfoster self-assigned this Jun 21, 2022
@oliverfoster oliverfoster requested a review from joe-replin June 21, 2022 15:14
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-replin
joe-replin approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@joe-replin joe-replin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented into my project as well as a master build. Works great, thank you!

@oliverfoster oliverfoster merged commit 40250ca into master Jul 4, 2022
@oliverfoster oliverfoster deleted the issue/145 branch July 4, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-replin joe-replin joe-replin approved these changes

Assignees

@oliverfoster oliverfoster

Labels
accessibility enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverfoster @joe-replin @cahirodoherty-learningpool @eleanor-heath