Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequential Aria Level Headers #145

Closed
joe-replin opened this issue Jun 20, 2022 · 1 comment · Fixed by #146
Closed

Sequential Aria Level Headers #145

joe-replin opened this issue Jun 20, 2022 · 1 comment · Fixed by #146

Comments

@joe-replin
Copy link
Contributor

joe-replin commented Jun 20, 2022

Bug Description:

Aria level headers get skipped in numbering when article headers & block headers are not present.

Steps to Reproduce:

Using a screen reader, navigate through the headings, noting the heading level of each one.

Actual Behavior:

When article & block headers are not present, heading levels will start at 1 for a page header and move to 4 for subsequent headers, with no mention of 2 or 3. Adapt currently assigns heading levels to the following elements:

  • heading level 1 for page headers
  • heading level 2 for article headers
  • heading level 3 for block headers
  • heading level 4 for component headers
  • heading level 5 for component item headers

Expected Behavior:

From https://www.w3.org/WAI/tutorials/page-structure/headings/
Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a h2 is not followed directly by an h4, for example. It is ok to skip ranks when closing subsections, for instance, a h2 beginning a new section, can follow an h4 as it closes the previous section.

This would mean Adapt dynamically assigning aria heading levels to each level. A component would adopt a heading level of 2 if an article or block header did not currently exist.

@oliverfoster
Copy link
Member

oliverfoster commented Jun 21, 2022

We can give it a shot, I haven't automated it because I'm never quite sure how the final content is to be structured and whether we can make the above assumptions? To me this is a design issue, not a code issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants