Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tx example #14

Merged
merged 4 commits into from
Jul 24, 2018
Merged

Add tx example #14

merged 4 commits into from
Jul 24, 2018

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Jul 24, 2018

Fixes #9

@kattni kattni requested a review from caternuson July 24, 2018 18:07
caternuson
caternuson requested changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@caternuson caternuson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested and works. Requests are basically cosmetic.

examples/ir_transmit.py
# Create a button object to trigger IR transmit
button = digitalio.DigitalInOut(board.D4)
button.direction = digitalio.Direction.INPUT
button.pull = digitalio.Pull.DOWN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be digitalio.Pull.UP to match essentials guide, etc? would require changing the conditional in the loop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buttons are backwards on the CPX. So either this or the loop will be backwards for CPX or an external button. We'll leave it as CPX for now and consider changing it if we receive a bunch of feedback.

examples/ir_transmit.py
zero=[550, 1700], trail=0)

while True:
if button.value:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above about using digitalio.Pull.UP

examples/ir_transmit.py
zero=[550, 1700], trail=0)

while True:
if button.value:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a print("sending code") or something here so there's indication in REPL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Adding now.

caternuson
caternuson requested changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@caternuson caternuson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more

examples/ir_transmit.py Outdated
# Create a button object to trigger IR transmit
button = digitalio.DigitalInOut(board.D4)
button.direction = digitalio.Direction.INPUT
# This is for CPX. For an external button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment seems truncated?
"Using internal pull downs for CPX button compatibility. For other external buttons, either change or do the same."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I got halfway though this idea and gave up on it, forgot to delete it. Fixing.

@caternuson caternuson merged commit 0c89a08 into adafruit:master Jul 24, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 7, 2018
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@e893f58)
c2a61bd 
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.1.0 from 3.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#7 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#6 from margaret/issue_5
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.1.0 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#19 from kattni/pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#18 from caternuson/iss17
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#16 from caternuson/iss7
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#15 from caternuson/iss13b
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#14 from caternuson/iss13
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#12 from caternuson/iss3
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#11 from caternuson/iss3
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#10 from elmwoodelec/master
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#6 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 3.3.0 from 3.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#15 from kattni/pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#14 from kattni/add-tx-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.2.0 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#11 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#10 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_L3GD20 to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#4 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#3 from mrmcwethy/fixdocs

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303 to 1.2.0 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303#5 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS0 to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS0#5 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS0#3 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#7 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#5 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#3 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixKe to 1.1.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixKe#2 from kattni/badge-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixKe#1 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31855 to 3.0.3 from 3.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31855#7 from kattni/fixes

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31865 to 2.1.0 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#6 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#13 from kattni/lint-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#12 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#11 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX9744 to 1.1.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#6 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#5 from sommersoft/new_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#4 from sommersoft/new_docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2 to 1.1.0 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP2#3 from kattni/pypi
  > updated CoC
  > attack of the typo
  > Get ready to PyPI
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP2#2 from adafruit/deshipu-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4725 to 1.1.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP4725#5 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.2.0 from 3.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#14 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_MMA8451 to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#2 from kattni/pypi
  > updated CoC
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#1 from jepler/import-struct

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL3115A2 to 1.1.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#3 from kattni/pypi
  > updated CoC

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 1.1.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#7 from kattni/pypi
  > updated CoC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caternuson caternuson caternuson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kattni @caternuson