Add support for 1.2" 4-Digit 7-Segment Displays #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 11, 2018 18:47
kattni
suggested changes
Jul 13, 2018
adafruit_ht16k33/segments.py
Outdated
| if self._auto_write: | ||
| self.show() | ||
|
|
||
| #pylint: disable=W0212 |
There was a problem hiding this comment.
We prefer you use the spelled out version of the disables. Please update this to reflect the error in that format. For example: # pylint: disable=too-many-arguments.
| def __getitem__(self, key): | ||
| if key > self._num_of_colons - 1: | ||
| raise ValueError("Trying to access a non-existent colon.") | ||
| return bool(self._disp._get_buffer(0x04) & self.MASKS[key]) |
There was a problem hiding this comment.
I would suggest adding the # pylint: enable=your-lint-complaint wherever it needs to be in the event that something is eventually added to the end of this file. I'm not certain where it needs to go - it may need to encompass the entire class, or it may be able to go on line 205. Please experiment to find the best location for it.
There was a problem hiding this comment.
Moved it to inside the class. The disables apparently work at a code block level, so I think this should limit to with the class itself.
kattni
approved these changes
Jul 13, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 7, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.1.0 from 3.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#7 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_GPS#6 from margaret/issue_5 > Merge pull request adafruit/Adafruit_CircuitPython_GPS#4 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.1.0 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#19 from kattni/pypi > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#18 from caternuson/iss17 > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#16 from caternuson/iss7 > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#15 from caternuson/iss13b > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#14 from caternuson/iss13 > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#12 from caternuson/iss3 > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#11 from caternuson/iss3 > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#10 from elmwoodelec/master > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#6 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 3.3.0 from 3.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#15 from kattni/pypi > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#14 from kattni/add-tx-example Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.2.0 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#11 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#10 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_L3GD20 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#3 from mrmcwethy/fixdocs Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303 to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_LSM303#5 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_LSM303#4 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS0 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS0#5 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS0#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#7 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#5 from sommersoft/new_docs > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixKe to 1.1.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixKe#2 from kattni/badge-fix > Merge pull request adafruit/Adafruit_CircuitPython_MatrixKe#1 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31855 to 3.0.3 from 3.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_MAX31855#7 from kattni/fixes Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31865 to 2.1.0 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#6 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#13 from kattni/lint-fix > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#12 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#11 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX9744 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#6 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#5 from sommersoft/new_docs > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#4 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2 to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_MCP2#3 from kattni/pypi > updated CoC > attack of the typo > Get ready to PyPI > Merge pull request adafruit/Adafruit_CircuitPython_MCP2#2 from adafruit/deshipu-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4725 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_MCP4725#5 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.2.0 from 3.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#14 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_MMA8451 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#2 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#1 from jepler/import-struct Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL3115A2 to 1.1.0 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#3 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#7 from kattni/pypi > updated CoC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for 1.2" 4-Digit 7-Segment Displays for #17 .
These displays have some differences from the 0.56" 7-segment displays. There are no decimal places. There are two colons and an AM/PM indicator, which are controlled like this:
I'm not super keen on the class name
BigSeg7x4if someone has a better suggestion.