refactor!: Unify floating point type for chi2 in Track(State)

[paulgessinger]

This was previously (not really intentionally) different.

[paulgessinger]

I'm changing the track state type to float first. I'm guessing this has an impact on the fit results, but let's see.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abae9b3) 49.73% compared to head (c0a3258) 49.73%.
Report is 1 commits behind head on main.

❗ Current head c0a3258 differs from pull request most recent head 4887d19. Consider uploading reports for the commit 4887d19 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2562   +/-   ##
=======================================
  Coverage   49.73%   49.73%           
=======================================
  Files         474      474           
  Lines       26872    26872           
  Branches    12364    12364           
=======================================
  Hits        13366    13366           
  Misses       4702     4702           
  Partials     8804     8804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 4887d19

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[paulgessinger]

Seems like output hashes change (makes sense), but physmon is unchanged.

[kodiakhq]

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

[benjaminhuth]

Is this breaking actually? Because it touches the concept and so on?

[paulgessinger]

@benjaminhuth Depends I guess.

[paulgessinger]

Failures after #2094 went in, as this still expects the other type.

[tboldagh]

Just in case this would need to be changed once more is there some Acts::Scalar type for float that could be used instead of explicity type?

[paulgessinger]

@tboldagh There is, but I'm wondering if that makes sense. Is the goal really to have everything use the same precision? I can't imagine we would actually ever need double for things like this $\chi^2$ value.

[acts-project-service]

🔴 Athena integration test results [040a896]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🔴	run_unit_tests
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data

[tboldagh]

@tboldagh There is, but I'm wondering if that makes sense. Is the goal really to have everything use the same precision? I can't imagine we would actually ever need double for things like this
χ2 value.

I was acually suggesting (indirectly and eveidently not very suggestive way) that a type: Acts::SmallScalar could be defined and used in this case.
(the name sould be better of course).

[paulgessinger]

@tboldagh Seems like a wider discussion. Should we merge this to start with so we can land it in Athena soon?

[tboldagh]

@tboldagh Seems like a wider discussion. Should we merge this to start with so we can land it in Athena soon?

Yes. Definitely.

[tboldagh]

Yes, this looks alright.
Maybe I tag @CarloVarni - we will need to update xAOD class when this arrives in ATLAS.
This is breaking change (in a not so pleasent way - missing update will result in quite obscure runtime issue). If I understood well the discussion at last ACTS developers, there was plan to flag such breaking changes.

[timadye]

Just to be clear, the effect of this PR is that the TrackState chi2 type changes from double to float, right?

The v31.0.0 release notes has it the other way round in the Breaking section. Can the release notes be fixed, or it made clear at the top of this PR?

[paulgessinger]

@timadye My mistake, sorry! Fixed in the release notes now.