feat: Add PODIO plugin, Track EDM backend #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was using `unsigned long long` before, but that's not actually guaranteed to be `uint64_t` on all platforms
…ement access
This changes the contract between `TrackContainer`, `MultiTrajectory`
and their backends. Notably it
- Adds dedicated methods for surface manipulation that are used by the
backend:
- `referenceSurface_impl` to get a reference surface
by index. It returns a pointer, and a new method
`hasReferenceSurface` on the proxies compares it to `nullptr` to
check if a reference surface is set
- `setReferenceSurface_impl` to set a reference surface
- `has_impl` for both backend types is not expected to respond to `referenceSurface` anymore.
- In `MultiTrajectory`, the backend is no longer expected to return an
index referencing a jacobian, measurement or measurement covariance.
Instead, the dedicated methods `jacobian_impl`, `measurement_impl` and
`measurementCovariance_impl` are now called by the proxy with the
state index directly, leaving the backend to implement index
traversal. `has_impl` is not expected to respond to `calibrated`,
`calibratedCov`, `jacobian` anymore.
This allows us to use these tests more like a compliance suite, and it can be used to test other backend implementation (like the upcoming PODIO one)
This PR adds a self-contained PODIO plugin, independent from the EDM4hep plugin. It implements backends for the `TrackContainer` and `MultiTrajectory` EDM. Tests are included for conversion of both EDM types.
Codecov Report
@@ Coverage Diff @@
## main #2094 +/- ##
=======================================
Coverage ? 49.64%
=======================================
Files ? 471
Lines ? 26632
Branches ? 12237
=======================================
Hits ? 13222
Misses ? 4742
Partials ? 8668
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
asalzburger
previously approved these changes
Aug 29, 2023
|
This adds a few unit tests, and I believe those should run, yes. |
|
This is green once again. @asalzburger can you have a look? |
asalzburger
approved these changes
Oct 23, 2023
acts-project-service
added
the
Fails Athena tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a self-contained PODIO plugin, independent from the EDM4hep plugin. It implements backends for the
TrackContainerandMultiTrajectoryEDM. Tests are included for conversion of both EDM types.Blocked by: