Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove effectiveProjector() from collector() in GX2F #2556

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Oct 18, 2023

We were discussing a bit (starting from #2511 ) if we can remove effectiveProjector from the collector in the GlobalChiSquareFitter, since it is not very efficient. This PR now removes it.

@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2556 (a21b58f) into main (5035479) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2556      +/-   ##
==========================================
- Coverage   49.76%   49.76%   -0.01%     
==========================================
  Files         466      466              
  Lines       26351    26353       +2     
  Branches    12098    12100       +2     
==========================================
  Hits        13114    13114              
  Misses       4632     4632              
- Partials     8605     8607       +2     
Files Coverage Δ
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 39.53% <0.00%> (-0.47%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AJPfleger AJPfleger changed the title docs: update collector() comments in GX2F feat: remove effectiveProjector() from collector() in GX2F Oct 19, 2023
@AJPfleger AJPfleger changed the title feat: remove effectiveProjector() from collector() in GX2F refactor: remove effectiveProjector() from collector() in GX2F Oct 19, 2023
@benjaminhuth benjaminhuth added this to the next milestone Oct 19, 2023
@kodiakhq kodiakhq bot merged commit 244b280 into acts-project:main Oct 19, 2023
@AJPfleger AJPfleger deleted the gx2f-proj branch October 21, 2023 16:54
@paulgessinger paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants