-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove effectiveProjector()
from collector()
in GX2F
#2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2556 +/- ##
==========================================
- Coverage 49.76% 49.76% -0.01%
==========================================
Files 466 466
Lines 26351 26353 +2
Branches 12098 12100 +2
==========================================
Hits 13114 13114
Misses 4632 4632
- Partials 8605 8607 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
approved these changes
Oct 19, 2023
effectiveProjector()
from collector()
in GX2F
effectiveProjector()
from collector()
in GX2FeffectiveProjector()
from collector()
in GX2F
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were discussing a bit (starting from #2511 ) if we can remove
effectiveProjector
from the collector in the GlobalChiSquareFitter, since it is not very efficient. This PR now removes it.