-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fill track in GX2F #2511
feat: Fill track in GX2F #2511
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2511 +/- ##
=======================================
Coverage 49.82% 49.82%
=======================================
Files 468 468
Lines 26509 26539 +30
Branches 12180 12197 +17
=======================================
+ Hits 13209 13224 +15
+ Misses 4633 4632 -1
- Partials 8667 8683 +16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 1: Only (very) nitpicky comments
I started a review but realized I have no idea what is going on ^^
I will pass by your office tomorrow before continuing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me other than that, but I think a tracking expert should have another look at this
d0d9be9
to
72f857a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
Changes I suggest can be done in a follow-up PR imo, because it's still correct the way it's done right now.
Next generalisation of the Global Chi Square Fitter (GX2F). Now it can fill a track with reasonable trackStates.
This will be followed by an PR including a python example (truth_tracking) to analyse the root-outputs.
Keep in mind, that some of the trackStates still might not be filled with the correct values.