fix: Fix boundaries navigation

[andiwand]

I encountered looping navigation between boundary surfaces as we do the lookup with overstep limit.

I believe we do not want to look for any boundaries that are behind us? But I might overlook something

Pulled this out of #2518

blocked by

• test: Refactor GX2F test #2545
• refactor: Make Fatras Particle and simulation surface aware #2546

[paulgessinger]

What if we slightly overstep onto a boundary surface? Then we want to go backwards to get to it, don't we?

[andiwand]

What if we slightly overstep onto a boundary surface? Then we want to go backwards to get to it, don't we?

That should still be the case. When we target a boundary the navigator will try to reach it and handle overstepping. But when we look up boundaries after we changed volumes we do not want to look back I think

[paulgessinger]

This fails the global $\chi^2$ fitter test. Can you have a look @andiwand?

[github-actions]

📊: Physics performance monitoring for 2849632

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[codecov]

Codecov Report

Merging #2534 (2849632) into main (630fc20) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2534   +/-   ##
=======================================
  Coverage   49.64%   49.64%           
=======================================
  Files         471      471           
  Lines       26632    26632           
  Branches    12237    12237           
=======================================
  Hits        13222    13222           
  Misses       4742     4742           
  Partials     8668     8668           

Files	Coverage Δ
Core/src/Geometry/TrackingVolume.cpp	47.64% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[acts-project-service]

✅ Athena integration test results [f84610d]

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data