feat: add material conversion + test for TGeo

[asalzburger]

This is a first PR in a set of a series PRs to establish the ODD in the new Detector schema.

This particular PR adds the possibility to convert material via TGeoMaterial and adds tests for this.
It also cleans ups the TGeoSurface converter slightly.

Note:

• due to internal unit change of ROOT up to 6.25.01 the unit tests on this Material conversion test is enables only for ROOT versions after this change.

[AJPfleger]

In multiple place the factor 2 * is introduced. Why?

[asalzburger]

In multiple place the factor 2 * is introduced. Why?

That was a bug - but this code what not yet used, the half length and length was wrongly matched.
It becomes relevant now as I use the thickness/half thickness for the Material condensing.

[github-actions]

📊: Physics performance monitoring for 572a539

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[asalzburger]

It is indeed the TGeoConversion to change output. Checking this in detail now.

Invalidated by push of 4cd855a

[asalzburger]

The change happens in
ProtoLayer where we estimate the layer with
double thickness = element->thickness();
Nothings serious, but enough to change output.

I will verify the correct behaviour and if correct, change the references.

[codecov]

Codecov Report

Merging #2496 (7158a65) into main (e349434) will not change coverage.
The diff coverage is n/a.

❗ Current head 7158a65 differs from pull request most recent head 572a539. Consider uploading reports for the commit 572a539 to get more accurate results

@@           Coverage Diff           @@
##             main    #2496   +/-   ##
=======================================
  Coverage   49.81%   49.81%           
=======================================
  Files         466      466           
  Lines       26253    26253           
  Branches    12054    12054           
=======================================
  Hits        13077    13077           
  Misses       4606     4606           
  Partials     8570     8570           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[asalzburger]

Hey @AJPfleger - I have checked that this behaviour is correct now (and have put this information also into the unit tests).

Thus, I updated the references.

[asalzburger]

The tiny differences in the test_examples are expected due to thickness change of the ODD detector

Invalidated by push of f460c07

[asalzburger]

Merging this after approval and updating references.

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data

[osbornjd]

@asalzburger After updating from v30.0.0 to v30.3.0 I have found that this PR (and specifically the factor of 2 in the TGeoSurfaceConverter discussed above) leads to an error message in our geometry building that looks like the following:

09:41:23    LayerArrayCr   ERROR     Layers are overlapping at: 367.247. This should never happen. Please check your geometry description.

This happens for all of our TPC layers where we create fake boxes that approximate the pad plane readout layers. It turns out if I remove this factor of 2 from a local build these error messages go away, as is the case in v30.0.0. The really strange part is that the code functions completely normally with v30.3.0, passes all CI and performance checks etc. So the error message is somehow anamolous. I'll find a way to suppress it for now but can you comment further on why this change was made and if we should expect this behavior? It says above that this was a bug but the boxes that we build in TGeo have not had any overlap issues and we have a TGeo overlap check in our CI that runs and it does not warn about any overlaps. Perhaps there is some difference in definition or expectation between the Acts geometry and TGeo geometry that we are somehow mixing up?