Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use electron hypothesis for GSF #2471

Merged
merged 6 commits into from
Sep 25, 2023
Merged

fix: Use electron hypothesis for GSF #2471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58d7734
try it!
benjaminhuth Sep 20, 2023
3c88dce
test pdg
benjaminhuth Sep 20, 2023
33aace1
fix
benjaminhuth Sep 25, 2023
93520e9
update references
benjaminhuth Sep 25, 2023
aa4affd
Merge branch 'main' into fix/gsf-truth-tracking-electron-hypothesis
benjaminhuth Sep 25, 2023
1a4b712
Merge branch 'main' into fix/gsf-truth-tracking-electron-hypothesis
benjaminhuth Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified CI/physmon/reference/performance_gsf.root
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion Core/include/Acts/EventData/ParticleHypothesis.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class SinglyChargedParticleHypothesis
return SinglyChargedParticleHypothesis(PdgParticle::ePionPlus);
}
static SinglyChargedParticleHypothesis electron() {
return SinglyChargedParticleHypothesis(PdgParticle::ePionPlus);
return SinglyChargedParticleHypothesis(PdgParticle::eElectron);
}

static SinglyChargedParticleHypothesis chargedGeantino() {
Expand Down
5 changes: 5 additions & 0 deletions Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/ParticleSmearing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ ActsExamples::ParticleSmearing::ParticleSmearing(const Config& config,
throw std::invalid_argument("Missing random numbers tool");
}

if (m_cfg.particleHypothesis) {
ACTS_INFO("Override truth particle hypothesis with "
<< *m_cfg.particleHypothesis);
}

m_inputParticles.initialize(m_cfg.inputParticles);
m_outputTrackParameters.initialize(m_cfg.outputTrackParameters);
}
Expand Down
8 changes: 4 additions & 4 deletions Examples/Python/tests/root_file_hashes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ test_truth_tracking_kalman[odd-0.0]__performance_track_finder.root: 39aec6316cce
test_truth_tracking_kalman[odd-1000.0]__trackstates_fitter.root: 04ec5361f32eae9151497c54d89c2a0b03a088050be7a37f521f65cd3abf85c8
test_truth_tracking_kalman[odd-1000.0]__tracksummary_fitter.root: 2a6de6dedd20acae66eef29649a0966f0b83ea00cee9475fbaaca696058b2525
test_truth_tracking_kalman[odd-1000.0]__performance_track_finder.root: 39aec6316cceb90e314e16b02947faa691c18f57c3a851a25e547a8fc05a4593
test_truth_tracking_gsf[generic]__trackstates_gsf.root: d2ea2f83e7737cc3d48d0c06e832d381e9e1041226361631f05a1962a9ed8fbd
test_truth_tracking_gsf[generic]__tracksummary_gsf.root: d51143362b51e7b4ee9d6aaab3083db6f7784c14589d90a16213642aa605e78f
test_truth_tracking_gsf[odd]__trackstates_gsf.root: 1b1d3be665abe75a5b400db3df9f2a6fbc1a193ea7a5e238a51a1f212e50e414
test_truth_tracking_gsf[odd]__tracksummary_gsf.root: e707c8ca54ba404e7a5e0a4ad77c746445fc10ba9d8ab87c726721ebe09163e4
test_truth_tracking_gsf[generic]__trackstates_gsf.root: 8d09c4c31bf65866645b779ceb764b2efabe82c64e2bdc84d77e343a8249ca4d
test_truth_tracking_gsf[generic]__tracksummary_gsf.root: 91a6451e0fc87434cd60422127a8cd8d6ac01cd5390c75b24c446cbf2ff42e4c
test_truth_tracking_gsf[odd]__trackstates_gsf.root: eb41b01e4a9913af2e59a3fef792104ff0c4119d1985aa0d03e84fb921ea3214
test_truth_tracking_gsf[odd]__tracksummary_gsf.root: 94ee433af1c3b84dbf7ac3a52f73abdba5ea2143a5c13f63163f64952715c6b5
test_particle_gun__particles.root: 8549ba6e20338004ab8ba299fc65e1ee5071985b46df8f77f887cb6fef56a8ec
test_material_mapping__material-map_tracks.root: 4e1c866038f0c06b099aa74fd01c3d875f07b89f54898f90debd9b558d8e4025
test_material_mapping__propagation-material.root: 646b8e2bbacec40d0bc4132236f9ab3f03b088e656e6e9b80c47ae03eaf6eab5
Expand Down
2 changes: 1 addition & 1 deletion Examples/Scripts/Python/truth_tracking_gsf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ def runTruthTrackingGsf(
decorators=[],
s=None,
):

from acts.examples.simulation import (
addParticleGun,
EtaConfig,
Expand Down Expand Up @@ -89,6 +88,7 @@ def runTruthTrackingGsf(
trackingGeometry,
field,
seedingAlgorithm=SeedingAlgorithm.TruthSmeared,
particleHypothesis=acts.ParticleHypothesis.electron,
)

truthTrkFndAlg = acts.examples.TruthTrackFinder(
Expand Down