Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use electron hypothesis for GSF #2471

Conversation

benjaminhuth
Copy link
Member

self explaining

@benjaminhuth benjaminhuth added this to the next milestone Sep 20, 2023
andiwand
andiwand previously approved these changes Sep 20, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

I guess this will change the reference

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Sep 20, 2023
@benjaminhuth benjaminhuth marked this pull request as draft September 20, 2023 11:01
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2471 (aa4affd) into main (c92cded) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head aa4affd differs from pull request most recent head 1a4b712. Consider uploading reports for the commit 1a4b712 to get more accurate results

@@           Coverage Diff           @@
##             main    #2471   +/-   ##
=======================================
  Coverage   49.90%   49.90%           
=======================================
  Files         466      466           
  Lines       26231    26231           
  Branches    12013    12013           
=======================================
  Hits        13090    13090           
  Misses       4613     4613           
  Partials     8528     8528           
Files Changed Coverage Δ
Core/include/Acts/EventData/ParticleHypothesis.hpp 68.57% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger modified the milestones: next, v30.0.0 Sep 25, 2023
@andiwand
Copy link
Contributor

pulls look a bit better especially for theta. happy to approve after updating the reference

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Sep 25, 2023
@benjaminhuth benjaminhuth marked this pull request as ready for review September 25, 2023 13:11
@kodiakhq kodiakhq bot merged commit ac8ec6e into acts-project:main Sep 25, 2023
AJPfleger pushed a commit to AJPfleger/acts that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Event Data Model Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants