Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: time vertex seeding #2460

Merged
merged 39 commits into from
Oct 6, 2023
Merged

Conversation

felix-russo
Copy link
Contributor

@felix-russo felix-russo commented Sep 18, 2023

The AdaptiveGridTrackDensity is adapted to accommodate time vertex seeding. Unit tests are added.

In the unit tests, the analytical maximum and width of a 3D Gaussian along the z-axis is used, see Gaussian_Track_Density.pdf for a derivation.

@github-actions github-actions bot added Component - Core Affects the Core module Vertexing labels Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2460 (3214bbe) into main (9f0b3e4) will decrease coverage by 0.01%.
The diff coverage is 54.31%.

@@            Coverage Diff             @@
##             main    #2460      +/-   ##
==========================================
- Coverage   49.78%   49.77%   -0.01%     
==========================================
  Files         466      466              
  Lines       26272    26298      +26     
  Branches    12069    12084      +15     
==========================================
+ Hits        13079    13091      +12     
  Misses       4617     4617              
- Partials     8576     8590      +14     
Files Coverage Δ
...Acts/Vertexing/AdaptiveGridDensityVertexFinder.hpp 100.00% <ø> (ø)
...nclude/Acts/Vertexing/AdaptiveGridTrackDensity.hpp 100.00% <100.00%> (ø)
...Acts/Vertexing/AdaptiveGridDensityVertexFinder.ipp 51.94% <40.00%> (ø)
...nclude/Acts/Vertexing/AdaptiveGridTrackDensity.ipp 57.50% <53.00%> (-3.66%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@felix-russo felix-russo marked this pull request as ready for review September 27, 2023 12:14
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part 1

@paulgessinger paulgessinger added this to the next milestone Sep 29, 2023
@andiwand
Copy link
Contributor

andiwand commented Oct 4, 2023

sorry I did not take a second look yet. is this ready for a fresh second round @felix-russo ?

@felix-russo
Copy link
Contributor Author

Yes, should be good to go @andiwand :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants