-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: time vertex seeding #2460
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2460 +/- ##
==========================================
- Coverage 49.78% 49.77% -0.01%
==========================================
Files 466 466
Lines 26272 26298 +26
Branches 12069 12084 +15
==========================================
+ Hits 13079 13091 +12
Misses 4617 4617
- Partials 8576 8590 +14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This reverts commit 7569241.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
part 1
sorry I did not take a second look yet. is this ready for a fresh second round @felix-russo ? |
Yes, should be good to go @andiwand :) |
The
AdaptiveGridTrackDensity
is adapted to accommodate time vertex seeding. Unit tests are added.In the unit tests, the analytical maximum and width of a 3D Gaussian along the
z
-axis is used, see Gaussian_Track_Density.pdf for a derivation.