refactor: Use separate column for previous in MTJ #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2425 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 455 455
Lines 25840 25840
Branches 11861 11860 -1
=======================================
Hits 12843 12843
Misses 4592 4592
Partials 8405 8405
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
felix-russo
approved these changes
Sep 8, 2023
|
I just messed that up yeah 🙄 |
|
Happens to the best :) |
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
A track can now initiate forward linking of its track states. The track states have a new property, `next` that optionally makes the sequence a doubly linked list. This is not filled by default (not even by `appendTrackState`) because for branching cases, it's not unambiguous. `linkForward()` on a track will initiate the forward linking and store the innermost track state index for easy access. `reverseTrackStates` also does this, since it's only valid for non-branching trackstate sequences anyway. Also adds a `innermostTrackState()` getter, which returns a track state proxy in case the track is forward linked and has a `stemIndex` Blocked by: - #2425 - #2426
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
A track can now initiate forward linking of its track states. The track states have a new property, `next` that optionally makes the sequence a doubly linked list. This is not filled by default (not even by `appendTrackState`) because for branching cases, it's not unambiguous. `linkForward()` on a track will initiate the forward linking and store the innermost track state index for easy access. `reverseTrackStates` also does this, since it's only valid for non-branching trackstate sequences anyway. Also adds a `innermostTrackState()` getter, which returns a track state proxy in case the track is forward linked and has a `stemIndex` Blocked by: - acts-project#2425 - acts-project#2426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously still using the
ipreviousmember inIndexData, but we did have a separatem_previouscolumn already that was being ignored.Preparation for #2418